-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resize app icon #45
Resize app icon #45
Conversation
Have you tested this at different scaling factors? E.g. 100%, 150%, 200%.
Please add screenshots and explain what you did to the icon.
Thank you
…On Fri, 9 Oct. 2020, 2:27 am Ori A, ***@***.***> wrote:
Fixes #33
<#33>
------------------------------
You can view, comment on, or merge this pull request online at:
#45
Commit Summary
- Resize app icon
File Changes
- *M* src/PackageManager.UI/Views/Assets/box-search-result.ico
<https://github.com/gitextensions/gitextensions.pluginmanager/pull/45/files#diff-24853bbc5473e73e95324477a100f9df>
(0)
- *M* src/PackageManager.UI/Views/Assets/box-search-result.png
<https://github.com/gitextensions/gitextensions.pluginmanager/pull/45/files#diff-686fb55fd8811d981d05f4c5f37e773c>
(0)
Patch Links:
-
https://github.com/gitextensions/gitextensions.pluginmanager/pull/45.patch
-
https://github.com/gitextensions/gitextensions.pluginmanager/pull/45.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#45>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABBTEXVMSPRVHJJJBURMBPTSJXK7XANCNFSM4SI5AQ4Q>
.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I wrote the issue, I was thinking of searching/creating a new icon rather than upscaling the existing.
However, the upscaled version still looks much better than the current one. So for me the PR is fine.
Works for me, thanks.
Martin your call.
…On Fri, 9 Oct. 2020, 7:59 am Ori A, ***@***.***> wrote:
Please add screenshots and explain what you did to the icon.
I simply upscaled it with a professional tool.
Have you tested this at different scaling factors? E.g. 100%, 150%, 200%.
Screenshots:
150%
[image: 150]
<https://user-images.githubusercontent.com/14019835/95512745-fa714f00-09c1-11eb-84f4-bd48fa728bbb.png>
125%
[image: 125]
<https://user-images.githubusercontent.com/14019835/95512749-fba27c00-09c1-11eb-9da7-f08992e1eef7.png>
100%
[image: 100]
<https://user-images.githubusercontent.com/14019835/95512751-fc3b1280-09c1-11eb-93c7-53afa2d57dd0.png>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#45 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABBTEXUKTN77GBVMERYRWILSJYR2LANCNFSM4SI5AQ4Q>
.
|
Thank you. |
You're welcome! |
Fixes #33