Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resize app icon #45

Merged
merged 1 commit into from
Oct 8, 2020
Merged

Resize app icon #45

merged 1 commit into from
Oct 8, 2020

Conversation

oriash93
Copy link
Contributor

@oriash93 oriash93 commented Oct 8, 2020

Fixes #33

@RussKie
Copy link
Member

RussKie commented Oct 8, 2020 via email

Copy link
Member

@mast-eu mast-eu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I wrote the issue, I was thinking of searching/creating a new icon rather than upscaling the existing.
However, the upscaled version still looks much better than the current one. So for me the PR is fine.

@oriash93
Copy link
Contributor Author

oriash93 commented Oct 8, 2020

Please add screenshots and explain what you did to the icon.

I simply upscaled it with a professional tool.

Have you tested this at different scaling factors? E.g. 100%, 150%, 200%.

Screenshots:
150%
150

125%
125

100%
100

@RussKie
Copy link
Member

RussKie commented Oct 8, 2020 via email

@mast-eu mast-eu merged commit 274c1e3 into gitextensions:master Oct 8, 2020
@mast-eu
Copy link
Member

mast-eu commented Oct 8, 2020

Thank you.

@oriash93
Copy link
Contributor Author

oriash93 commented Oct 8, 2020

You're welcome!
One small thing - can you please mark this PR or repo as eligible for hacktoberfest?

@mast-eu mast-eu added this to the 1.2.0 milestone Oct 30, 2020
@oriash93 oriash93 deleted the oriash93/resize_icon branch June 12, 2021 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icon too small
4 participants