Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(#17) updated TargetFramework to net6.0-windows7.0 #18

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

(#17) updated TargetFramework to net6.0-windows7.0 #18

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f318055
(#17) updated TargetFramework to net6.0-windows7.0
nils-a Mar 20, 2023
6388295
Implemented changes from discussion
nils-a Mar 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/GitExtensions.PluginTemplate/GitExtensions.PluginTemplate.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net461</TargetFramework>
<TargetFramework>net6.0-windows7.0</TargetFramework>
nils-a marked this conversation as resolved.
Show resolved Hide resolved
<UseWindowsForms>true</UseWindowsForms>
<VersionPrefix>1.0.0</VersionPrefix>
<PublishRepositoryUrl>true</PublishRepositoryUrl>
</PropertyGroup>
Expand All @@ -18,12 +19,14 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="GitExtensions.Extensibility" Version="0.1.1.40" />
<PackageReference Include="GitExtensions.Extensibility" Version="0.3.0.57" />
nils-a marked this conversation as resolved.
Show resolved Hide resolved
<PackageReference Include="Microsoft.VisualStudio.Composition" Version="17.4.16" />
<PackageReference Include="Microsoft.VisualStudio.threading" Version="17.5.22" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need these two?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Plugin Manager we have System.ComponentModel.Composition with 6.0.0 and that's enough. I think we had some problems when referencing VS MEF in Plugin Manager.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good point. We can only use versions used in the main app: https://github.com/gitextensions/gitextensions/blob/master/Packages.props#L18-L20
But since we'd be referencing the main app, I'm curious why we need these here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, we just reference main app specific dlls. It doesn't add indirect references to the build, right? And so we need some MEF to be able compile the plugin dll.

Maybe could add all/some package reference from main app to the GitExtensions.Extensibility

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I "only" copied those from the Gerrit plugin. I was wondering, though, why it was those instead of System.ComponentModel.Composition.
I'm perfectly happy to change those for something better. Referencing Microsoft.VisualStudio.* feels weird.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove these completely unless we have a strong justification. In case we do, we should document it here.

</ItemGroup>

<!--SourceLink support: https://github.com/dotnet/sourcelink -->
<ItemGroup>
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.0.0" PrivateAssets="All"/>
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.0.0" PrivateAssets="All" />
<!--<PackageReference Include="Microsoft.SourceLink.AzureRepos.Git" Version="1.0.0" PrivateAssets="All"/>-->
<!--<PackageReference Include="Microsoft.SourceLink.AzureDevOpsServer.Git" Version="1.0.0" PrivateAssets="All"/>-->
<!--<PackageReference Include="Microsoft.SourceLink.GitLab" Version="1.0.0" PrivateAssets="All"/>-->
Expand Down
12 changes: 8 additions & 4 deletions src/GitExtensions.PluginTemplate/GitExtensions.PluginTemplate.csproj.user
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,12 @@
<Project>
<PropertyGroup>
<GitExtensionsDownloadPath>..\..\..\gitextensions.shared</GitExtensionsDownloadPath> <!-- path is relative to $(ProjectDir) -->
<GitExtensionsReferenceVersion>latest</GitExtensionsReferenceVersion> <!-- 'latest' or 'v3.1' (= tag from GitHub releases) or 'v3.1.0.5877' (= build number from AppVeyor)-->
<GitExtensionsReferenceSource>GitHub</GitExtensionsReferenceSource> <!-- 'GitHub' or 'AppYevor' -->
<GitExtensionsPath></GitExtensionsPath> <!-- for local builds (no download) -->
<!-- path is relative to $(ProjectDir) -->
<GitExtensionsDownloadPath>..\..\..\gitextensions.shared</GitExtensionsDownloadPath>
<!-- 'latest' or 'v3.1' (= tag from GitHub releases) or 'v3.1.0.5877' (= build number from AppVeyor)-->
<GitExtensionsReferenceVersion>latest</GitExtensionsReferenceVersion>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to add a section to readme under Good Practices stating that GitExtensionsReferenceVersion used for local development should be synchronized with GitExtensions.Extensibility package version, so local dev loop and published package targets the same version of Git Extensions.

It's out of scope of this PR, so if you don't want to write it, I can do it in a separate PR

Copy link
Author

@nils-a nils-a Mar 21, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not so good on words, but I'll give it a try.

I'm uncertain if I get what you mean, here.
GitExtensions.Extensibility "only" ensures a local copy of Git Extensions exists for local development. It "only" provides the preBuild and the postBuild targets, does it not?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It also adds a dependency in the built nuget package and we use this dependency to validate that the package is intended for the current main app version (we still have gaps in this area, but in general 0.3 means targeting Git Extensions v4).

As we don't have a stable API yet, you typically need to "hack" into what Git Extensions give you in the current plugin API, and so it is important to build against "similar" version that you the plugin to run in (most of my plugins needs at least recompilation between main app version upgrades).

Using "latest" can be dangerous, because it may download even preview version.

<!-- 'GitHub' or 'AppYevor' -->
<GitExtensionsReferenceSource>GitHub</GitExtensionsReferenceSource>
<!-- for local builds (no download) -->
<GitExtensionsPath>$(GitExtensionsDownloadPath)</GitExtensionsPath>
</PropertyGroup>
</Project>
3 changes: 2 additions & 1 deletion src/GitExtensions.PluginTemplate/Properties/launchSettings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@
"profiles": {
"GitExtensions.PluginTemplate": {
"commandName": "Executable",
"executablePath": "$(GitExtensionsExecutablePath)"
"executablePath": "$(GitExtensionsExecutablePath)",
"workingDirectory": "$(MSBuildProjectDirectory)"
}
}
}