Refactor how are handled boolean git settings

GitUI/CommandsDialogs/SettingsDialog/Pages/GitConfigAdvancedSettingsPage.cs

@@ -1,32 +1,54 @@
-using Microsoft;
+using System.Collections.Generic;
+using System.Windows.Forms;
+using Microsoft;
 
 namespace GitUI.CommandsDialogs.SettingsDialog.Pages
 {
     public partial class GitConfigAdvancedSettingsPage : ConfigFileSettingsPage
     {
+        private readonly Dictionary<string, CheckBox> _gitSettings = new();
+
         public GitConfigAdvancedSettingsPage()
         {
             InitializeComponent();
             Text = "Advanced";
             InitializeComplete();
+            FillGitSettings();
+            Load += GitConfigAdvancedSettingsPage_Load;
+        }
+
+        private void FillGitSettings()
+        {
+            _gitSettings.Add("pull.rebase", checkBoxPullRebase);
+            _gitSettings.Add("fetch.prune", checkBoxFetchPrune);
+            _gitSettings.Add("rebase.autoStash", checkBoxRebaseAutostash);
+            _gitSettings.Add("rebase.autosquash", checkBoxRebaseAutosquash);
+        }
+
+        private void GitConfigAdvancedSettingsPage_Load(object? sender, System.EventArgs e)
+        {
+            foreach (KeyValuePair<string, CheckBox> gitSetting in _gitSettings)
+            {
+                gitSetting.Value.Text += $" [{gitSetting.Key}]";
+            }
         }
 
         protected override void SettingsToPage()
         {
             Validates.NotNull(CurrentSettings);
-            checkBoxPullRebase.Checked = CurrentSettings.GetValue("pull.rebase") == "true";
-            checkBoxFetchPrune.Checked = CurrentSettings.GetValue("fetch.prune") == "true";
-            checkBoxRebaseAutostash.Checked = CurrentSettings.GetValue("rebase.autoStash") == "true";
-            checkBoxRebaseAutosquash.Checked = CurrentSettings.GetValue("rebase.autosquash") == "true";
+            foreach (KeyValuePair<string, CheckBox> gitSetting in _gitSettings)
+            {
+                gitSetting.Value.Checked = CurrentSettings.GetValue(gitSetting.Key) == "true";
+            }
         }
 
         protected override void PageToSettings()
         {
             Validates.NotNull(CurrentSettings);
-            CurrentSettings.SetValue("pull.rebase", checkBoxPullRebase.Checked ? "true" : "false");
-            CurrentSettings.SetValue("fetch.prune", checkBoxFetchPrune.Checked ? "true" : "false");
-            CurrentSettings.SetValue("rebase.autoStash", checkBoxRebaseAutostash.Checked ? "true" : "false");
-            CurrentSettings.SetValue("rebase.autosquash", checkBoxRebaseAutosquash.Checked ? "true" : "false");
+            foreach (KeyValuePair<string, CheckBox> gitSetting in _gitSettings)
+            {
+                CurrentSettings.SetValue(gitSetting.Key, gitSetting.Value.Checked ? "true" : "false");
+            }
         }
     }
 }

GitUI/Translation/English.xlf

@@ -8029,6 +8029,10 @@ Context menu for additional operations</source>
         <source>Rebase local branch when pulling (instead of merge)</source>
         <target />
       </trans-unit>
+      <trans-unit id="checkBoxRebaseAutosquash.Text">
+        <source>Automatically squash commits when doing an interactive rebase</source>
+        <target />
+      </trans-unit>
       <trans-unit id="checkBoxRebaseAutostash.Text">
         <source>Automatically stash before doing a rebase</source>
         <target />