Handle more exceptions as failed external operation

gitextensions · Apr 15, 2021 · 9a9c8ae · 9a9c8ae
1 parent 606769b
commit 9a9c8ae
Showing 1 changed file with 13 additions and 4 deletions.
diff --git a/GitUI/NBugReports/BugReporter.cs b/GitUI/NBugReports/BugReporter.cs
@@ -1,4 +1,7 @@
 using System;
+using System.ComponentModel;
+using System.IO;
+using System.Security;
 using System.Text;
 using System.Windows.Forms;
 using GitExtUtils;
@@ -65,7 +68,13 @@ void AppendIfNotEmpty(string? value, string designation)
         public static void Report(Exception exception, bool isTerminating)
         {
             bool isUserExternalOperation = exception is UserExternalOperationException;
-            bool isExternalOperation = exception is ExternalOperationException;
+            bool isExternalOperation = exception is ExternalOperationException
+                                                 or IOException
+                                                 or SecurityException
+                                                 or FileNotFoundException
+                                                 or DirectoryNotFoundException
+                                                 or PathTooLongException
+                                                 or Win32Exception;
 
             StringBuilder text = new();
             string rootError = Append(text, exception);
@@ -97,7 +106,7 @@ public static void Report(Exception exception, bool isTerminating)
             taskDialogCommandLink.Click += (s, e) =>
                 {
                     taskDialog.Close();
-                    ShowNBug(OwnerForm, exception, isTerminating);
+                    ShowNBug(OwnerForm, exception, isExternalOperation, isTerminating);
                 };
             taskDialog.Controls.Add(taskDialogCommandLink);
 
@@ -120,14 +129,14 @@ void AddIgnoreOrCloseButton()
             }
         }
 
-        private static void ShowNBug(IWin32Window? owner, Exception exception, bool isTerminating)
+        private static void ShowNBug(IWin32Window? owner, Exception exception, bool isExternalOperation, bool isTerminating)
         {
             var envInfo = UserEnvironmentInformation.GetInformation();
 
             using BugReportForm form = new();
             DialogResult result = form.ShowDialog(owner, exception, envInfo,
                 canIgnore: !isTerminating,
-                showIgnore: exception is ExternalOperationException,
+                showIgnore: isExternalOperation,
                 focusDetails: exception is UserExternalOperationException);
             if (isTerminating || result == DialogResult.Abort)
             {