Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File History window: last commit is hidden under action bar #11071

Closed
radist-nt opened this issue Jun 25, 2023 · 3 comments · Fixed by #11201
Closed

File History window: last commit is hidden under action bar #11071

radist-nt opened this issue Jun 25, 2023 · 3 comments · Fixed by #11201
Labels

Comments

@radist-nt
Copy link

Environment

  • Git Extensions 4.1.0.16698
  • Build 1fe52a1
  • Git 2.39.0.windows.2 (recommended: 2.40.1 or later)
  • Microsoft Windows NT 10.0.19043.0
  • .NET 6.0.19
  • DPI 96dpi (no scaling)
  • Portable: False
  • Microsoft.WindowsDesktop.App Versions
    Microsoft.WindowsDesktop.App 6.0.19 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]

Issue description

File History window's action bar hides the very first commit in the commits area.

Expected behavior:
The last commit is showed on the first line below the action bar. User is able to select that commit with mouse click.

Actual behavior:
The last commit is hidden by the action bar. User can select that commit by clicking the previous commit and pressing UP key.
The selection is slightly visible, but it's not possible to read any data from that line.
screenshot

Steps to reproduce

  1. Settings: Git Extensions -> Detailed -> Browse repository; uncheck parameters "Show file history in the main window" and "Show blame in diff viewer"
  2. Select any frequently modifier file from File Tree, press H or select "View history" from context menu
  3. On commits area in File History window uncheck the following items in context menu -> View: "Show artificial commits", "Show stashes" (this is need to make the problem obvious)

Did this work in previous version of GitExtensions?

I think, it worked in 3.5.x versions,
The bug wa noticed after upgrading to 4.0.2

Diagnostics

No response

@mstv
Copy link
Member

mstv commented Jun 27, 2023

Nudging, advertising workaround: 😉

image

@radist-nt
Copy link
Author

Nudging, advertising workaround: 😉

Thank you, but NO! Convenient window splitter layout for brosing file history and for browsing repository history are completely different. Also, sometimes I need to open several history windows (and I want to distinguish them from the main window).
When developers will decide to remove File History window, I'll just stop updating.

@mstv
Copy link
Member

mstv commented Jun 27, 2023

Convenient window splitter layout for brosing file history and for browsing repository history are completely different.

We might consider storing a separate set of splitter positions. Which layout do you prefer?

I need to open several history windows (and I want to distinguish them from the main window).

Just open multiple histories using the hotkey H.

The title bar is different, and the Left Panel is hidden automatically.

image

@ghost ghost added the 🚧 status: in progress Issues which have associated PRs label Sep 10, 2023
@ghost ghost removed the 🚧 status: in progress Issues which have associated PRs label Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants