Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception after closing File History dialog (from Commit Dialog) which was not completely loaded #1317

Closed
feinstaub opened this issue Oct 15, 2012 · 8 comments

Comments

@feinstaub
Copy link
Contributor

Reproduce:

  1. Change some files
  2. Open Commit Dialog
  3. Right click on a changed file and click "View file history"
  4. Close the File History dialog before the Loading is finished
  5. Exception occurs.
@jbialobr
Copy link
Member

Exceptions ocurrs in many places.

Example 1:
syncContext.Post(state1 => UpdateColumnWidth(), null);
Example 2:
syncContext.Post(_ =>
{
FileChanges.FixedFilter = filter;
FileChanges.AllowGraphWithFilter = true;
FileChanges.Load();
}, null);

It is queued and invoked in main thread after control was disposed.
All fragments like aboves have to be rewriten to ensure that they are not operating on diposed data.

@feinstaub
Copy link
Contributor Author

Thanks for the explanation. With the current dev version I cannot reproduce the issue anymore. I'll wait for the next release and check again.

@KindDragon
Copy link
Contributor

I close this bug. Please comment if you can reproduce it.

@jbialobr
Copy link
Member

I can reproduce, the slower computer you have the more exceptions occur.

@KindDragon KindDragon reopened this Oct 18, 2012
@jbialobr
Copy link
Member

After closed GE commit info tries to load.

        if (Settings.CommitInfoShowContainedInTags)
            ThreadPool.QueueUserWorkItem(_ => loadTagInfo(_revision));

@feinstaub
Copy link
Contributor Author

@jbialobr Can you still reproduce it? I can't.

@jbialobr
Copy link
Member

Yes, I can.

@feinstaub
Copy link
Contributor Author

ok, I'll leave the issue open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants