GitCommands.Settings#GetGitExtensionsDirectory: Crash if fileName.LastIndexOfAny returns -1

[pcworld]

Application crashes when GitCommands.Settings#GetGitExtensionsDirectory is called and fileName.LastIndexOfAny returns -1.

Can Assembly.GetAssembly(typeof(Settings)).Location be replaced by something else?
I'm currently trying to turn GitExt into a .NET-independent executable with mkbundle, works pretty well so far (with some workarounds) and the resulting binaries are only of a few MB in size, no .NET or full Mono needed to run it, as the necessary Mono libraries are bundled with the executable.
But when trying to open the settings dialog, GitExt crashes. Will have to debug later, but I guess Assembly.GetAssembly(typeof(Settings)).Location is an empty string or something.

[jbialobr]

Can you try to build it from branch jb/1790?

[pcworld]

Cherry-picked 79cb936, fixed the problem. Thanks

[jbialobr]

I am curious how it will work on wine. Could you share somewhere exe?

[pcworld]

This is 2.44 with 5387b6a and 79cb936 applied, compiled with Xamarin Studio (except for a few DLLs that were taken from the 2.44 release zip and the Mono directory): gitext_standalone.7z (sha256: 1d24105864a83282e66c220dfd98f77db8f267557539a0049ca75db841bc76c1)
If the commit summary should stay empty when launching aaa_gitext.exe, you need to add one of the I18N* DLLs from Mono-3.0.6\lib\mono\4.5 to the extracted directory.

Note that mkbundle also works on Linux/OS X, so one should be able to create native binaries for these OSs as well, so wine shouldn't be necessary.

[KindDragon]

Every new window crash for me this GitEx

[pcworld]

@KindDragon:

Every new window crash for me this GitEx

You mean the binaries I posted above? And you tried them on Windows?
If so, when you select a commit, does it show the commit summary at the bottom? If not, you probably need some I18N DLL from Mono-3.0.6\lib\mono\4.5 because of your locale.
(If you don't have Mono, here's the missing I18N DLLs (sha256: a5c4c39bb007a97fbc776876a342f761d4c1709517be46f43c58f639a86b044c), extract it to the folder where the GitExt standalone exe is.)

[KindDragon]

You mean the binaries I posted above? And you tried them on Windows?

Yes

If not, you probably need some I18N DLL from Mono-3.0.6\lib\mono\4.5 because of your locale.

This doesn't help, also gravatar image is corrupted.

[KindDragon]

This is just for informations.