Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot set path to Git.exe if it is in a non-standard folder #2235

Closed
PhilipDaniels opened this issue Feb 3, 2014 · 0 comments
Closed

Cannot set path to Git.exe if it is in a non-standard folder #2235

PhilipDaniels opened this issue Feb 3, 2014 · 0 comments

Comments

@PhilipDaniels
Copy link
Contributor

I have installed a portable version of MSysGit in folder C:\PublicHome\OtherApps\PortableGit.

The settings page does not permit this to be picked because it requires git (and incidentally, cygwin) to be in a certain set of well-known folders (see function GetGitLocations() in CheckSettingsLogic.cs)

I have made a fix which I will be pushing to my fork. Basically, if the user browses or types or pastes into the "git path" or "sh path" boxes we allow it if that file exists. GetGitLocations therefore still works for trying to guess where git is located upon initial install, but the user is allowed to pick anywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants