Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show non-printing characters in commit dialog: Differentiate between LF and CRLF end-of-lines #2373

Closed
carleeto opened this issue Jun 26, 2014 · 5 comments
Labels
area: user experience type: feature request up-for-grabs Easy tasks for those looking to get involved. Refer to https://up-for-grabs.net/

Comments

@carleeto
Copy link

I have version 2.47.3 on Windows 7.

When I am in the commit window, I always have "show non-printing characters" on.
The problem is that, regardless of whether the file has DOS or UNIX line endings, I see the same symbol (http://www.fileformat.info/info/unicode/char/b6/index.htm) at the end of the line.

This means that when the only change in a file is the end of line character, show non-printing characters is not helpful.

Solution:
There needs to be different symbols for different line endings.
Perhaps something from this page: http://www.fileformat.info/info/unicode/block/control_pictures/images.htm

@carleeto carleeto changed the title non-printing characters Show non-printing characters in commit dialog: Differentiate between LF and CRLF end-of-lines Jun 26, 2014
@CoperNick8
Copy link

@Kryptos-FR
Copy link

Kryptos-FR commented Mar 4, 2019

Recently realized I needed that feature, not only in the commit dialog, but in the "diff" view tab as well.

For working copy files, I can just open it in an editor supporting that feature (such has Notepad++) but for files in other commits, I need to go to the file tree and do "open this revision with... (temp file)" which is time consuming.

Would you mind assigning a milestone to that issue (and maybe the "up for grab" tag)?
Thanks.

@RussKie RussKie added the up-for-grabs Easy tasks for those looking to get involved. Refer to https://up-for-grabs.net/ label Mar 4, 2019
@RussKie
Copy link
Member

RussKie commented Mar 4, 2019

@Kryptos-FR assigning a milestone means the core team commits to implementing a feature/fix a bug by the due date.

PRs implementing the feature are welcome.

@Kryptos-FR
Copy link

@RussKie understood.

@mstv
Copy link
Member

mstv commented Nov 13, 2021

Done with #9620

@mstv mstv closed this as completed Nov 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: user experience type: feature request up-for-grabs Easy tasks for those looking to get involved. Refer to https://up-for-grabs.net/
Projects
None yet
Development

No branches or pull requests

6 participants