Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revision header's height is short if Japanese font is selected #2670

Closed
msakuta opened this issue Feb 22, 2015 · 0 comments
Closed

Revision header's height is short if Japanese font is selected #2670

msakuta opened this issue Feb 22, 2015 · 0 comments

Comments

@msakuta
Copy link
Contributor

msakuta commented Feb 22, 2015

The revision header in the commit log window has insufficient height for its contents.
It shows a vertical scroll bar, but I cannot see the "Parent(s)" line without scrolling.

image

This issue won't happen when a non-Japanese font is selected in Settings -> Appearance -> Application font. I've confirmed this issue with MS UI Gothic, MS P Gothic and Meiryo. Other multibyte fonts may suffer from the same problem, but I didn't check further.

I've looked into the code and figured out that RichTextBox.GetPreferredSize() has a bug it could return a wrong size. The safe way to fit a RichTextBox's height to its contents is, as described in the page on the following URL, to respond to ContentsResized event.

http://csharphelper.com/blog/2013/07/resize-a-richtextbox-to-fit-its-contents-in-c/

I'll post a pull request for this fix.

msakuta added a commit to msakuta/gitextensions that referenced this issue Feb 22, 2015
Yasami added a commit to Yasami/gitextensions that referenced this issue Dec 23, 2015
Fixed issue gitextensions#2670: Revision header too short if Japanese font is used
@jbialobr jbialobr added this to the 2.50 milestone Apr 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants