On Diff/File List pane got exception ArgumentOutOfRangeException InvalidArgument Value of -1 is not valid for index

[vsevolodp]

File names become moved right for some reason. After that I get exception when moving mouse to clear region on left of file names.
Unfortunately I can not find pattern when moving occurs.

Exception: System.ArgumentOutOfRangeException
Message: InvalidArgument=Value of '-1' is not valid for 'index'.
         Parameter name: index
Target Site: ListViewSubItem get_Item(Int32) @ System.Windows.Forms.ListViewItem+ListViewSubItemCollection
Source: System.Windows.Forms
Stack Trace:
   at System.Windows.Forms.ListViewItem.ListViewSubItemCollection.get_Item(Int32 index)
   at System.Windows.Forms.ListView.HitTest(Int32 x, Int32 y)
   at System.Windows.Forms.ListView.HitTest(Point point)
   at GitUI.FileStatusList.FileStatusListView_MouseMove(Object sender, MouseEventArgs e)
   at System.Windows.Forms.Control.WmMouseMove(Message& m)
   at System.Windows.Forms.Control.WndProc(Message& m)
   at System.Windows.Forms.ListView.WndProc(Message& m)
   at GitUI.UserControls.ExListView.WndProc(Message& m)
   at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)
ParamName: index
HResult: -2146233086

[kimitop]

In revision grid,choose a commit which difffile list shows the scrollbar to click,drag the scroll to the right end. Then choose another commit which difffile list shows no scrollbar. Then the difffile list will be strange begin with lots of whitespace. Then move the mouse to the whitespace place will occur the bug.

[danlyons-softek]

I still get these semi-frequently in 2.49:

I have the Periodic background fetch set to run once a minute and automatically refresh the view, which causes the diff list to re-populate. Occasionally, when it reloads the list, it will have a large amount of whitespace on the left side and explode on mouse-over as kimitop explains above.

I usually leave the view on the diff tab, so I cannot say for sure if it still happens to the file list.

[vbjay]

A minute seems a bit much. Try every 5-6 minutes.

…

On Thu, Jan 12, 2017, 3:56 PM Dan Lyons ***@***.***> wrote: I still get these semi-frequently in 2.49: [image: diff_list_exception] <https://cloud.githubusercontent.com/assets/3289668/21907721/58c1b2a0-d8d6-11e6-8598-618a665b796f.png> I have the Periodic background fetch set to run once a minute and automatically refresh the view, which causes the diff list to re-populate. Occasionally, when it reloads the list, it will have a large amount of whitespace on the left side and explode on mouse-over as kimitop explains above. I usually leave the view on the diff tab, so I cannot say for sure if it still happens to the file list. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#2759 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADdhsZJ8gwbxRCZGsbh_7a7UD2MSLQDOks5rRpNUgaJpZM4D3uZk> .

[jbialobr]

@danlyons-softek Can you provide the callstack for your exception?

[vsevolodp]

Just saw same exception as @danlyons-softek mentioned above. All versions are same.

Second tab content

Exception: System.ArgumentOutOfRangeException
Message: InvalidArgument=Value of '-1' is not valid for 'index'.
    Parameter name: index
Target Site: ListViewSubItem get_Item(Int32) @ System.Windows.Forms.ListViewItem+ListViewSubItemCollection
Source: System.Windows.Forms
Stack Trace
   at System.Windows.Forms.ListViewItem.ListViewSubItemCollection.get_Item(Int32 index)
   at System.Windows.Forms.ListView.HitTest(Int32 x, Int32 y)
   at System.Windows.Forms.ListView.HitTest(Point point)
   at GitUI.FileStatusList.FileStatusListView_MouseMove(Object sender, MouseEventArgs e)
   at System.Windows.Forms.Control.OnMouseMove(MouseEventArgs e)
   at System.Windows.Forms.Control.WmMouseMove(Message& m)
   at System.Windows.Forms.Control.WndProc(Message& m)
   at System.Windows.Forms.ListView.WndProc(Message& m)
   at GitUI.UserControls.ExListView.WndProc(Message& m)
   at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)
ParamName: index
HResult: -2146233086

[vsevolodp]

How to reproduce

1. Select commit, go to Diff tab, make sure there is no horisontal scroll bar, resize left pane to show scroll bar
   

2. Scroll to most right
   

3. Go to File tree tab
   

4. Go back to Diff tab and rezise it to make wider than content
   

[danlyons-softek]

The reproduction is actually even simpler: you can skip step 3:

1. Shrink the diff list until a scroll bar appears
2. Scroll all the way to the right
3. Expand the diff list past the point where the scroll bar disappears

At this point, there will be a gap to the left of the diff list.

Note that I also get the same stack trace:
at System.Windows.Forms.ListViewItem.ListViewSubItemCollection.get_Item(Int32 index)
at System.Windows.Forms.ListView.HitTest(Int32 x, Int32 y)
at System.Windows.Forms.ListView.HitTest(Point point)
at GitUI.FileStatusList.FileStatusListView_MouseMove(Object sender, MouseEventArgs e)
at System.Windows.Forms.Control.OnMouseMove(MouseEventArgs e)
at System.Windows.Forms.Control.WmMouseMove(Message& m)
at System.Windows.Forms.Control.WndProc(Message& m)
at System.Windows.Forms.ListView.WndProc(Message& m)
at GitUI.UserControls.ExListView.WndProc(Message& m)
at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)

[vsevolodp]

And this is reproducable on 12546ca

[jbialobr]

Fixed in a434093.
I do not know how to prevent listview from being missaligned.