Clicking Commit causes a crash #3827
Comments
|
Can you post the full stack trace? gitextensions/GitUI/SpellChecker/EditNetSpell.cs Line 1065 in 03e78fe You can try this fix, though arguably it is a mere workaround rather than fix: |
|
Exception Stack Trace: Little screenshot of the callstack: It's German, but "Zeile" means "Line". Hope this helps. The bandaid fix does work, to be sure. |
|
I am unable to repro the issue. Built in both Debug and Release, attached or detached, I've tried it on W7, W10 and Ubuntu. Does it happen for all git repos or only specific ones? Can you perhaps put a breakpoint in |
|
Im on windows 7 , it happens for all repos, Im building this using VS2015. A breakpoint on the first line of The exact Windows Version is: 6.1.7601 build 1130 (SP 1) |
|
Can you upload your gitui.dll？ I am afraid that you may have some changes to the editnetspell.cs? |
|
Wouldn't it be easier if I uploaded a complete windows build? |
|
Total C# novice here, but it sort of looks like the Here's my stacktrace: |
|
@Aldaviva I think you might just hit the jackpot here. |
In some circumstances SpellCheckEditControl could be initialised and start raising events before EditNetSpell control completed instantiation sequence. This would lead to NRE. The initialisation sequence adjusted to initialise SpellCheckEditControl after EditNetSpell control has loaded. Fixes gitextensions#3827
|
@default0 could you please try this build and see if the problem is fixed? |
|
Yep, that fixes it. |
In some circumstances SpellCheckEditControl could be initialised and start raising events before EditNetSpell control completed instantiation sequence. This would lead to NRE. The initialisation sequence adjusted to initialise SpellCheckEditControl after EditNetSpell control has loaded. Fixes #3827 (cherry picked from commit a9bd622)
Do you want to request a feature or report a bug?
This is a bug report.
What is the current behavior?
If I open my repository and click the "Commit" button I immediately get a NullReferenceException, crashing the application.
If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem.
Run the application without an attached debugger (building and running a built version w/ attached debugger made this issue cease to trigger). Now, after the application started, you can attach a debugger. Click "Commit" (and maybe make sure there are technically things to commit).
What is the expected behavior?
The Commit dialog opens
Which versions of GitExtensions, GIT and Windows are affected by this issue? Did this work in previous versions of our tool?
Versions affected were 2.50, 2.50.01 and all builds I could produce with the code from commit 76aa0ea.
The above steps trigger a NullReferenceException on EditNetSpell.cs on line 932, where the debugger shows that
_customUnderlinesis null. A quick inspection of the code lead me to believe that there's no conceivable way it should ever be null, since it's given a value in the constructor, so maybe the debugger is failing me, or there are other things going on that I won't understand unless I dig into the infrastructure of the project, which I would like to avoid.Advice/encouragement/a bugfix for this would be highly appreciated, as this effectively renders GitExtensions 2.50+ useless for me.
The text was updated successfully, but these errors were encountered: