Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

help picture disappeared when opening pull dialog #3829

Closed
zero2lin opened this issue Jul 10, 2017 · 3 comments
Closed

help picture disappeared when opening pull dialog #3829

zero2lin opened this issue Jul 10, 2017 · 3 comments

Comments

@zero2lin
Copy link

Here is a bug at v2.50.01.
When I open pull dialog, the help picture on the left doesn't show.

@nsartor
Copy link

nsartor commented Jul 10, 2017

I'm seeing this too. If you toggle the "Merge Options" radio buttons the help picture re-appears, but only while the dialog is open.

Running on Windows
git extensions

@RussKie
Copy link
Member

RussKie commented Jul 19, 2017

I witnessed it too on for a brand new installation of GitExtensions-2.50RC2-Setup.msi on Win8.1.
It wasn't my computer so I had no chance to debug it... 😞

@RussKie
Copy link
Member

RussKie commented Aug 19, 2017

Happened to me today while debugging other issues...

It looks like images aren't getting loaded and the panel gets the default dimensions
image

I will see if I can find out why...

RussKie added a commit to RussKie/gitextensions that referenced this issue Aug 19, 2017
Help images for helpImageDisplayUserControl1 are set whenever merge
options are changed - e.g. merge/rebase/don't merge.
The designer defaults to the first option (merge) after that the user
settings are applied.
If the user settings were set to 'merge' as well the change event would
not be triggered and images would not be set.

The designer default is unset, now the change event is triggered as expected.

Fixes gitextensions#3829
@RussKie RussKie added this to the 2.50.02 milestone Aug 19, 2017
RussKie added a commit that referenced this issue Aug 19, 2017
Help images for helpImageDisplayUserControl1 are set whenever merge
options are changed - e.g. merge/rebase/don't merge.
The designer defaults to the first option (merge) after that the user
settings are applied.
If the user settings were set to 'merge' as well the change event would
not be triggered and images would not be set.

The designer default is unset, now the change event is triggered as expected.

Fixes #3829

(cherry picked from commit cc65800)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants