Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Newtonsoft.Json on startup exception #3879

Closed
ardonjr opened this issue Aug 1, 2017 · 4 comments
Closed

Missing Newtonsoft.Json on startup exception #3879

ardonjr opened this issue Aug 1, 2017 · 4 comments

Comments

@ardonjr
Copy link

ardonjr commented Aug 1, 2017

gitext_error
Do you want to request a feature or report a bug?
Report a bug

What is the current behavior?
On startup I get the exception that Newtonsoft.Json is missing.

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem.
Just open GitExtensions. Version 2.50.01

What is the expected behavior?

Which versions of GitExtensions, GIT and Windows are affected by this issue? Did this work in previous versions of our tool?
GitExtensions: 2.50.01
GIT: git version 2.13.1.windows.1
Windows 10 Pro - 10.0.15063 Build 15063

@RussKie
Copy link
Member

RussKie commented Aug 1, 2017

Can you please check the content of your Plugins folder (usually something like C:\Program Files (x86)\GitExtensions\Plugins) - Newtonsoft.Json.dll should be there.
The version shipped with GE 2.50.01 is 10.0.2.20802

In GitExtensions.exe.config you should also have the following:

<configuration>
  <runtime>
    <assemblyBinding xmlns="urn:schemas-microsoft-com:asm.v1">
      <probing privatePath="plugins" />
      <dependentAssembly>
        <assemblyIdentity name="Newtonsoft.Json" publicKeyToken="30ad4fe6b2a6aeed" culture="neutral" />
        <bindingRedirect oldVersion="0.0.0.0-10.0.0.0" newVersion="10.0.0.0" />
      </dependentAssembly>
    </assemblyBinding>
  </runtime>

@ardonjr
Copy link
Author

ardonjr commented Aug 1, 2017

Thanks for the fast reply. I found the settings as mentioned to be correct however I do not have the Newtonsoft.Json.dll in the Plugins folder.
gitext_error_002

@ardonjr
Copy link
Author

ardonjr commented Aug 1, 2017

Nice. I "fixed" the issue by pulling a Newtonsoft.Json nuget package into an existing Visual Studio project and copied the DLL file into the C:\Program Files (x86)\GitExtensions\Plugins folder.
For now the exception is gone. But its strange that the dll isn't in place in the first place right?

@jbialobr
Copy link
Member

jbialobr commented Aug 1, 2017

Newtonsoft is only installed when either AppVeyorIntegration or Gerrit plugin is installed. We have to fix setup and include it also for the Stash plugin (and check if any other plugin requires Newtonsoft).

@jbialobr jbialobr added this to the 2.50.02 milestone Aug 1, 2017
RussKie added a commit to RussKie/gitextensions that referenced this issue Aug 3, 2017
RussKie added a commit to RussKie/gitextensions that referenced this issue Aug 3, 2017
@RussKie RussKie closed this as completed Aug 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants