Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.50.01 Quoting issues on git checkout command #3969

Closed
leak opened this issue Sep 5, 2017 · 4 comments
Closed

2.50.01 Quoting issues on git checkout command #3969

leak opened this issue Sep 5, 2017 · 4 comments

Comments

@leak
Copy link
Contributor

leak commented Sep 5, 2017

Do you want to request a feature or report a bug?
Potential bug but could also be misconfiguration, in the latter case I'd be thankful for pointers.

What is the current behavior?

When switching branches via toolbar the git checkout command is failing

"git" checkout "dashboard"
error: pathspec 'dashboard"' did not match any file(s) known to git.
Done

Press Enter or Esc to close console...

Notice the trailing double quote on the error line.

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem.

Problem is that I cannot reproduce the issue properly, currently it is occurring on two machines (all running same versions and OS) and one where it doesn't occure.
I have already reinstalled gitext, reset the configs or compared the configs between the working and non-working machines.
Additionally I have checked the PATH variable if there are any quoted paths, but I could not find any.

When running the command inside the console tab in gitext, it is completing properly.

What is the expected behavior?

The checkout command should complete without error as it does on command line.

Environment you encounter the issue:

  • GitExtensions version: 2.50.01
  • GIT version: 2.14.1.windows.1
  • OS version: Win10 x64

Did this work in previous version of GitExtensions (which)?
2.49.* seems to be fine

@RussKie
Copy link
Member

RussKie commented Sep 5, 2017 via email

@leak
Copy link
Contributor Author

leak commented Sep 5, 2017

The git command itself doesn't appear in the command log, I supposed because it is failing?

Also a screenshot doesn't provide more information, as it just contains the error I posted above:

image

**edit
This is the output when i use the same command including quotes from the console tab

$ git checkout "dashboard"
Switched to branch 'dashboard'
Your branch is up-to-date with 'origin/dashboard'.

@leak
Copy link
Contributor Author

leak commented Sep 5, 2017

As it turns out the console emulator is breaking the git command.

Thanks to @DDuarte

@DDuarte
Copy link
Contributor

DDuarte commented Sep 5, 2017

Seems to be related to #3864 and #3800

jbialobr added a commit that referenced this issue Sep 5, 2017
…3800.

Run scripts through the standard Process instead of conemu-inside - even if configured to use conemu.
Conemu-inside has a complex arguments parsing logic which is not able to handle correctly quoted parameters.
Fixes #3691.
@jbialobr jbialobr added this to the 2.50.02 milestone Sep 5, 2017
@jbialobr jbialobr closed this as completed Sep 5, 2017
jbialobr added a commit that referenced this issue Sep 5, 2017
…3800.

Run scripts through the standard Process instead of conemu-inside - even if configured to use conemu.
Conemu-inside has a complex arguments parsing logic which is not able to handle correctly quoted parameters.
Fixes #3691.

(cherry picked from commit b304969)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants