Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View summary of changes in revision grid #4281

Closed
gerhardol opened this issue Dec 27, 2017 · 7 comments
Closed

View summary of changes in revision grid #4281

gerhardol opened this issue Dec 27, 2017 · 7 comments

Comments

@gerhardol
Copy link
Member

gerhardol commented Dec 27, 2017

Do you want to request a feature or report a bug?
Feature

What is the current behavior?
The number of changes can be shown in the Commit button, together with some color coding to show the type of changes. It would be nice to see some more details, especially for artificial commits (#4209 adds support for the count for artificial commits). I would be most interested in submodule status, update needed or dirty, but also modified, new and deleted files.

The information can be presented in several ways:

  • New RevisionGrid column, available for all commits, so you can see simple/massive changes at a glance. Variable size though. the changes should be to the first parent only. This will have performance implications, calculating for all commits and should probably not be implemented.
  • First part of Subject column for artificial commits. Only for artificial commits then, can icons easily be blended with the text?
  • In toolbar, replacing the dynamic behavior of the Commit button. (Showing the aggregated status of unstaged/staged?)

One example. If the current unstaged changes look like this:
image

The column/entry to the unstaged message could be:
image:2 image:1 image: 1 image: 1

@RussKie
Copy link
Member

RussKie commented Dec 27, 2017

especially for artificial commits (#4247 adds support for the count for artificial commits but )

Do you mean #4209?
#4247 is about enabling them by default...

My apologies, but I've re-read the proposal several times and I am still unclear on the details (may be I need more sleep...I do actually)
You would like to visualise and provide more information on type of changes to submodules.
But I can't understand what this means:
image

@RussKie RussKie added this to the Next version milestone Dec 27, 2017
@gerhardol
Copy link
Member Author

Do you mean #4209?

Yes...

But I can't understand what this means:

A separate column or information merged to the Subject.

@gpongelli
Copy link
Contributor

What should appear on merge commit ?

@gerhardol
Copy link
Member Author

@gpongelli

What should appear on merge commit ?

The changes to the first master.
However, the performance implications are too high, a column available for all should probably not be implemented.

@gpongelli
Copy link
Contributor

However, the performance implications are too high

I think so.

@gerhardol gerhardol changed the title Column for changes compared to parent View summary of changes in revision grid Mar 10, 2018
@gerhardol
Copy link
Member Author

What I want to see are no of changed tracked files, untracked files (just for worktree) and changed submodules.
It would be nice to see the submodule status to see submodules that need to be updated, but that require calculations.

gerhardol added a commit to gerhardol/gitextensions that referenced this issue Jun 21, 2018
Implements gitextensions#4281
Show changed/new/deleted files and changed submodules
gerhardol added a commit to gerhardol/gitextensions that referenced this issue Jun 22, 2018
Implements gitextensions#4281
Show changed/new/deleted files and changed submodules
gerhardol added a commit to gerhardol/gitextensions that referenced this issue Jun 23, 2018
Implements gitextensions#4281
Show changed/new/deleted files and changed submodules
gerhardol added a commit to gerhardol/gitextensions that referenced this issue Jun 23, 2018
Implements gitextensions#4281
Show changed/new/deleted files and changed submodules
gerhardol added a commit to gerhardol/gitextensions that referenced this issue Jun 24, 2018
Implements gitextensions#4281
Show changed/new/deleted files and changed submodules
gerhardol added a commit to gerhardol/gitextensions that referenced this issue Jun 25, 2018
Implements gitextensions#4281
Show changed/new/deleted files and changed submodules
gerhardol added a commit to gerhardol/gitextensions that referenced this issue Jun 26, 2018
Implements gitextensions#4281
Show changed/new/deleted files and changed submodules
gerhardol added a commit to gerhardol/gitextensions that referenced this issue Jul 1, 2018
Implements gitextensions#4281
Show changed/new/deleted files and changed submodules
gerhardol added a commit to gerhardol/gitextensions that referenced this issue Jul 1, 2018
Implements gitextensions#4281
Show changed/new/deleted files and changed submodules
gerhardol added a commit to gerhardol/gitextensions that referenced this issue Jul 1, 2018
Implements gitextensions#4281
Show changed/new/deleted files and changed submodules
gerhardol added a commit to gerhardol/gitextensions that referenced this issue Jul 1, 2018
Implements gitextensions#4281
Show changed/new/deleted files and changed submodules
gerhardol added a commit to gerhardol/gitextensions that referenced this issue Jul 1, 2018
Implements gitextensions#4281
Show changed/new/deleted files and changed submodules
gerhardol added a commit to gerhardol/gitextensions that referenced this issue Jul 1, 2018
Implements gitextensions#4281
Show changed/new/deleted files and changed submodules
gerhardol added a commit to gerhardol/gitextensions that referenced this issue Jul 3, 2018
Implements gitextensions#4281
Show changed/new/deleted files and changed submodules
gerhardol added a commit to gerhardol/gitextensions that referenced this issue Jul 4, 2018
Implements gitextensions#4281
Show changed/new/deleted files and changed submodules
gerhardol added a commit to gerhardol/gitextensions that referenced this issue Jul 4, 2018
Implements gitextensions#4281
Show changed/new/deleted files and changed submodules
drewnoakes pushed a commit to drewnoakes/gitextensions that referenced this issue Jul 4, 2018
Implements gitextensions#4281
Show changed/new/deleted files and changed submodules
drewnoakes pushed a commit to drewnoakes/gitextensions that referenced this issue Jul 8, 2018
Implements gitextensions#4281
Show changed/new/deleted files and changed submodules
drewnoakes pushed a commit to drewnoakes/gitextensions that referenced this issue Jul 8, 2018
Implements gitextensions#4281
Show changed/new/deleted files and changed submodules
drewnoakes pushed a commit to drewnoakes/gitextensions that referenced this issue Jul 9, 2018
Implements gitextensions#4281
Show changed/new/deleted files and changed submodules
drewnoakes pushed a commit to drewnoakes/gitextensions that referenced this issue Jul 12, 2018
Implements gitextensions#4281
Show changed/new/deleted files and changed submodules
drewnoakes pushed a commit to drewnoakes/gitextensions that referenced this issue Jul 22, 2018
Implements gitextensions#4281
Show changed/new/deleted files and changed submodules
@gerhardol
Copy link
Member Author

Included as part of #5087

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants