Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visual Studio 2017 as default #4311

Closed
gerhardol opened this issue Jan 4, 2018 · 1 comment
Closed

Visual Studio 2017 as default #4311

gerhardol opened this issue Jan 4, 2018 · 1 comment
Labels
type: feature request
Milestone
3.00-beta1

Comments

@gerhardol
Copy link
Member

Do you want to request a feature or report a bug?
building problems, not functionality

What is the current behavior?
GE promotes VS2015, but VS2017 works too, also in AppVeyor.
Microsoft is quick to depreciate older Community versions. It is not possible to download VS2015 from Microsoft. I just found out that I have 14.1, but cannot upgrade to 14.3 (installer fails).

To be clear, I see no reason right now to depreciate VS2015 for building.
Also, this is not about the VS2010-2013 plugin (should be renamed to distinguish from GE plugins...). (I misunderstood that myself in #3362)

This is related to #4269, the build scripts can be simplified but this can cause VS2017 msbuild be selected before VS2015.

Environment you encounter the issue:

  • GitExtensions version: master
  • OS version: Win10

Did this work in previous version of GitExtensions (which)?
Continuously updating...
@RussKie RussKie added this to the Next version milestone Jan 13, 2018
This was referenced Jan 27, 2018
Open
Merged
@RussKie
Copy link
Member

RussKie commented Jan 30, 2018

I agree

gerhardol added a commit to gerhardol/gitextensions that referenced this issue Feb 4, 2018
@gerhardol
Set VS2017 as default
8cff4ce 
Issue gitextensions#4311
Building in AppVeyor with VS2017
This aligns the use of 2015/2017 as well as future versions and therefore removing MS2015 in filenames.
The known breaking future compatibility issues are new versions of .sln format as well as msbuild location (handled in hMSBuild.bat right now).

Also removed seemingly unused scripts and descriptions referring to MS2013 and older.
@gerhardol gerhardol mentioned this issue Feb 4, 2018
Merged
gerhardol added a commit to gerhardol/gitextensions that referenced this issue Feb 5, 2018
@gerhardol
Set VS2017 as default
a77d8c8 
Issue gitextensions#4311
Building in AppVeyor with VS2017
This aligns the use of 2015/2017 as well as future versions and therefore removing MS2015 in filenames.
The known breaking future compatibility issues are new versions of .sln format as well as msbuild location (handled in hMSBuild.bat right now).

Also removed seemingly unused scripts and descriptions referring to MS2013 and older.
gerhardol added a commit to gerhardol/gitextensions that referenced this issue Feb 6, 2018
@gerhardol
Set VS2017 as default
17c7e34 
Issue gitextensions#4311
Building in AppVeyor with VS2017
This aligns the use of 2015/2017 as well as future versions and therefore removing MS2015 in filenames.
The known breaking future compatibility issues are new versions of .sln format as well as msbuild location (handled in hMSBuild.bat right now).

Also removed seemingly unused scripts and descriptions referring to MS2013 and older.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: feature request
Projects
None yet
Milestone
3.00-beta1
Development

No branches or pull requests
2 participants
@RussKie @gerhardol