Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git update to 2.16.1 #4312

Closed
gerhardol opened this issue Jan 4, 2018 · 9 comments
Closed

Git update to 2.16.1 #4312

gerhardol opened this issue Jan 4, 2018 · 9 comments
Milestone

Comments

@gerhardol
Copy link
Member

Do you want to request a feature or report a bug?
feature

What is the current behavior?
2.51RC1 contains git 2.13. The latest version is 2.15.1. 2.16.RC0 exists too, 2.16 should be released in a couple of weeks.

I have used 2.15 since it was released, have not seen any problems.
There are to my knowledge no critical issues in 2.13 compared to 2.15. There are some submodule and LFS enhancements, currently only used from the command line.

GE should follow the Git releases when possible. Also stated in the documentation
https://github.com/gitextensions/gitextensions/wiki/Release-cycle

Environment you encounter the issue:

  • GitExtensions version: master
  • GIT version: 2.15.1
  • OS version: Win7/10

Did this work in previous version of GitExtensions (which)?
2.50 included the latest Git release at the time

@vbjay
Copy link
Contributor

vbjay commented Jan 4, 2018 via email

@RussKie RussKie added this to the Next version milestone Jan 13, 2018
@RussKie
Copy link
Member

RussKie commented Jan 30, 2018

Perhaps we just need to enhance our build/setup scripts to download the latest version available at the time of build.

@gerhardol
Copy link
Member Author

Should probably be manual, we do not know what is stable.
I plan to submit a PR for 2.15.1 after a build script update with a few simplifications (there should be a bigger take on the release process it seems)

@RussKie
Copy link
Member

RussKie commented Jan 30, 2018 via email

@gerhardol gerhardol changed the title Git update to 2.15.1 Git update to 2.16.1 Feb 4, 2018
@gerhardol
Copy link
Member Author

2.16.1 is working well for me (some fixes to reset since initial release)
I would prefer to not bundle Git with GE and just recommend the Git version on the home page...

@RussKie
Copy link
Member

RussKie commented Feb 4, 2018

I suppose we can modify the setup to check whether git is installed on the user's computer and prompt them to install it, if it is missing.

Probably do something like that for diff tools too, though at run time - if no diff tool is configured - prompt to configure/install?

gerhardol added a commit to gerhardol/gitextensions that referenced this issue Feb 4, 2018
gerhardol added a commit to gerhardol/gitextensions that referenced this issue Feb 4, 2018
@gerhardol
Copy link
Member Author

Submitted a PR for 2.16.1. Not a big deal also if we update later or select a better solution.

Downloading if not detected by the installer would be preferred, but the installer is supposedly difficult to modify in this way.
Ceck at startup is easier to implement. Separate issue?

@RussKie
Copy link
Member

RussKie commented Feb 6, 2018

Can it be closed?
If you use keywords, it'd happen automagically

@RussKie
Copy link
Member

RussKie commented Feb 6, 2018

Downloading if not detected by the installer would be preferred, but the installer is supposedly difficult to modify in this way.
Ceck at startup is easier to implement. Separate issue?

Yes, this issue is for the update.
Installer rework is a separate issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants