Submodules dialog: list is too narrow #4366
Labels
area: user experience
🤓 good first issue
up-for-grabs
Easy tasks for those looking to get involved. Refer to https://up-for-grabs.net/
Comments
|
Some screenshots would be nice, thanks |
|
You can change the size of the left panel (and the form), the size of the Name column will then be expanded. |
|
Sure, here is a dummy example: @gerhardol Sure I can resize it but next time I open the dialog, it is back to old size. |
|
Saving and restoring the size is pretty trivial fix.
The rest is a bit more involved, especially so if we account for Mono and
4K displays.
…On 19 January 2018 at 00:10, Hendrik Sattler ***@***.***> wrote:
Sure, here is a dummy example:
[image: 2018-01-18 14_05_50-submodules]
<https://user-images.githubusercontent.com/28525744/35099630-02d80a04-fc59-11e7-96aa-5b3c468553a0.png>
@gerhardol <https://github.com/gerhardol> Sure I can resize it but next
time I open the dialog, it is back to old size.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#4366 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEMyXknvhwsUF6DZhf6h3RovuWG5U_Vfks5tL0LXgaJpZM4Rg3-K>
.
|
gerhardol
added a commit
to gerhardol/gitextensions
that referenced
this issue
Mar 4, 2018
Fixes gitextensions#4564 Fixes gitextensions#4387 Fixes gitextensions#4396 Depends on gitextensions#4562 gitextensions#4663 gitextensions#4365 gitextensions#4366 gitextensions#4367 gitextensions#4368 Submitted to allow review of the outcome to gitextensions#4564 Note: Due to the structure of tests in a separate class, it is very difficult to split this issue in several commits Rewrote RevisionDiffController to make it possible to have some kind of tests. The tests are retrofitted to the current functionality as they are just testing the menu items and not the actions themselves. (The tests adds may more maintenance than they give benefits but the formal test coverage increases.) Browse Diff: Submodules actions available for multi select (gitextensions#4568) Presents the Reset options for the correct parent in multi select situations No longer differ between parent-child and first-second for Reset Difftool: Describes A and B revisions in the menu Difftool arguments depends on parent availability Better detection of parents to A/B for diffs Commit: Limit DiffTool and FileHistory to tracked FormDiff: Limit FileHistory to Tracked Use RevisionDiffController to align to Browse-Diff
gerhardol
added a commit
to gerhardol/gitextensions
that referenced
this issue
Mar 6, 2018
Fixes gitextensions#4564 Fixes gitextensions#4387 Fixes gitextensions#4396 Depends on gitextensions#4562 gitextensions#4663 gitextensions#4365 gitextensions#4366 gitextensions#4367 gitextensions#4368 Submitted to allow review of the outcome to gitextensions#4564 Note: Due to the structure of tests in a separate class, it is very difficult to split this issue in several commits Rewrote RevisionDiffController to make it possible to have some kind of tests. The tests are retrofitted to the current functionality as they are just testing the menu items and not the actions themselves. (The tests adds may more maintenance than they give benefits but the formal test coverage increases.) Browse Diff: Submodules actions available for multi select (gitextensions#4568) Presents the Reset options for the correct parent in multi select situations No longer differ between parent-child and first-second for Reset Difftool: Describes A and B revisions in the menu Difftool arguments depends on parent availability Better detection of parents to A/B for diffs Commit: Limit DiffTool and FileHistory to tracked FormDiff: Limit FileHistory to Tracked Use RevisionDiffController to align to Browse-Diff
gerhardol
added a commit
to gerhardol/gitextensions
that referenced
this issue
Mar 6, 2018
Fixes gitextensions#4564 Fixes gitextensions#4387 Fixes gitextensions#4396 Depends on gitextensions#4562 gitextensions#4663 gitextensions#4365 gitextensions#4366 gitextensions#4367 gitextensions#4368 Submitted to allow review of the outcome to gitextensions#4564 Note: Due to the structure of tests in a separate class, it is very difficult to split this issue in several commits Rewrote RevisionDiffController to make it possible to have some kind of tests. The tests are retrofitted to the current functionality as they are just testing the menu items and not the actions themselves. (The tests adds may more maintenance than they give benefits but the formal test coverage increases.) Browse Diff: Submodules actions available for multi select (gitextensions#4568) Presents the Reset options for the correct parent in multi select situations No longer differ between parent-child and first-second for Reset Difftool: Describes A and B revisions in the menu Difftool arguments depends on parent availability Better detection of parents to A/B for diffs Commit: Limit DiffTool and FileHistory to tracked FormDiff: Limit FileHistory to Tracked Use RevisionDiffController to align to Browse-Diff
gerhardol
added a commit
to gerhardol/gitextensions
that referenced
this issue
Mar 7, 2018
Fixes gitextensions#4564 Fixes gitextensions#4387 Fixes gitextensions#4396 Depends on gitextensions#4562 gitextensions#4663 gitextensions#4365 gitextensions#4366 gitextensions#4367 gitextensions#4368 Submitted to allow review of the outcome to gitextensions#4564 Note: Due to the structure of tests in a separate class, it is very difficult to split this issue in several commits Rewrote RevisionDiffController to make it possible to have some kind of tests. The tests are retrofitted to the current functionality as they are just testing the menu items and not the actions themselves. (The tests adds may more maintenance than they give benefits but the formal test coverage increases.) Browse Diff: Submodules actions available for multi select (gitextensions#4568) Presents the Reset options for the correct parent in multi select situations No longer differ between parent-child and first-second for Reset Difftool: Describes A and B revisions in the menu Difftool arguments depends on parent availability Better detection of parents to A/B for diffs Commit: Limit DiffTool and FileHistory to tracked FormDiff: Limit FileHistory to Tracked Use RevisionDiffController to align to Browse-Diff
gerhardol
added a commit
to gerhardol/gitextensions
that referenced
this issue
Mar 10, 2018
Fixes gitextensions#4564 Fixes gitextensions#4387 Fixes gitextensions#4396 Depends on gitextensions#4562 gitextensions#4663 gitextensions#4365 gitextensions#4366 gitextensions#4367 gitextensions#4368 Submitted to allow review of the outcome to gitextensions#4564 Note: Due to the structure of tests in a separate class, it is very difficult to split this issue in several commits Rewrote RevisionDiffController to make it possible to have some kind of tests. The tests are retrofitted to the current functionality as they are just testing the menu items and not the actions themselves. (The tests adds may more maintenance than they give benefits but the formal test coverage increases.) Browse Diff: Submodules actions available for multi select (gitextensions#4568) Presents the Reset options for the correct parent in multi select situations No longer differ between parent-child and first-second for Reset Difftool: Describes A and B revisions in the menu Difftool arguments depends on parent availability Better detection of parents to A/B for diffs Commit: Limit DiffTool and FileHistory to tracked FormDiff: Limit FileHistory to Tracked Use RevisionDiffController to align to Browse-Diff
gerhardol
added a commit
to gerhardol/gitextensions
that referenced
this issue
Mar 10, 2018
Fixes gitextensions#4564 Fixes gitextensions#4387 Fixes gitextensions#4396 Depends on gitextensions#4562 gitextensions#4663 gitextensions#4365 gitextensions#4366 gitextensions#4367 gitextensions#4368 Submitted to allow review of the outcome to gitextensions#4564 Note: Due to the structure of tests in a separate class, it is very difficult to split this issue in several commits Rewrote RevisionDiffController to make it possible to have some kind of tests. The tests are retrofitted to the current functionality as they are just testing the menu items and not the actions themselves. (The tests adds may more maintenance than they give benefits but the formal test coverage increases.) Browse Diff: Submodules actions available for multi select (gitextensions#4568) Presents the Reset options for the correct parent in multi select situations No longer differ between parent-child and first-second for Reset Difftool: Describes A and B revisions in the menu Difftool arguments depends on parent availability Better detection of parents to A/B for diffs Commit: Limit DiffTool and FileHistory to tracked FormDiff: Limit FileHistory to Tracked Use RevisionDiffController to align to Browse-Diff
gerhardol
added a commit
to gerhardol/gitextensions
that referenced
this issue
Mar 11, 2018
Fixes gitextensions#4564 Fixes gitextensions#4387 Fixes gitextensions#4396 Depends on gitextensions#4562 gitextensions#4663 gitextensions#4365 gitextensions#4366 gitextensions#4367 gitextensions#4368 Submitted to allow review of the outcome to gitextensions#4564 Note: Due to the structure of tests in a separate class, it is very difficult to split this issue in several commits Rewrote RevisionDiffController to make it possible to have some kind of tests. The tests are retrofitted to the current functionality as they are just testing the menu items and not the actions themselves. (The tests adds may more maintenance than they give benefits but the formal test coverage increases.) Browse Diff: Submodules actions available for multi select (gitextensions#4568) Presents the Reset options for the correct parent in multi select situations No longer differ between parent-child and first-second for Reset Difftool: Describes A and B revisions in the menu Difftool arguments depends on parent availability Better detection of parents to A/B for diffs Commit: Limit DiffTool and FileHistory to tracked FormDiff: Limit FileHistory to Tracked Use RevisionDiffController to align to Browse-Diff
gerhardol
added a commit
that referenced
this issue
Mar 18, 2018
* Browse Diff: Show differences for several selections * Browse Diff tab menu alternatives and presentation Fixes #4564 Fixes #4387 Fixes #4396 Depends on #4562 #4663 #4365 #4366 #4367 #4368 Rewrote RevisionDiffController to make it possible to have some kind of tests. The tests are retrofitted to the current functionality as they are just testing the menu items and not the actions themselves. (The tests adds may more maintenance than they give benefits but the formal test coverage increases.) Browse Diff: Submodules actions available for multi select (#4568) Presents the Reset options for the correct parent in multi select situations No longer differ between parent-child and first-second for Reset Difftool: Describes Selected (B) and First (A) revisions in the menu Difftool arguments depends on parent availability Better detection of parents to A/B for diffs Commit: Limit DiffTool and FileHistory to tracked FormDiff: Limit FileHistory to Tracked Use RevisionDiffController to align to Browse-Diff * Extract common revision diff context menu logic into IRevisionDiffContextMenuController
RussKie
added
up-for-grabs
ghost
added
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Do you want to request a feature or report a bug?
-> Bug
What is the current behavior?
When the dialog is show, the entry in the submodules list on the left side to not fit the table. For some, I can on see the elided prefix like "submodules/ABCD/..." multiple times. This makes the list rather useless.
If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem.
You need a repository with submodules that have a longer path.
What is the expected behavior?
Adapt the table to the widht of the content or at least save the state so the user can arrange it as needed and it stays like that even when the user opens the dialog again.
Environment you encounter the issue:
Did this work in previous version of GitExtensions (which)?
(unknown)
The text was updated successfully, but these errors were encountered: