Jira Commit Hint plugin credentials stored in plain text

[RussKie]

Do you want to request a feature or report a bug?
bug

What is the current behavior?
Credentials are stored in plain text

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem.
Choose to persist the settings into "Distributed with current repository" settings source (it doesn't matter which layer it is stored, this layer makes it easier to see)

Open the GitExtensions.settings file:

What is the expected behavior?
Password isn't stored at all.

The issue may not be a big deal for home users who rarely change passwords and do not share their computers with anyone. However in a corporate environments storing passwords in plain text, especially in settings, which may be committed into a public repository, is a massive security issue.
The username must not be persisted into a configuration file either. Credentials must be persisted into Windows Vault (credential store).
Few links to start with:

• https://msdn.microsoft.com/en-us/library/aa480470.aspx
• https://stackoverflow.com/questions/17741424/retrieve-credentials-from-windows-credentials-store-using-c-sharp

Environment you encounter the issue:
2.51 / master

/cc: @ierof @pmiossec

[ghost]

I think it is not bad solution, but there is a issue with current settings architecture and Credential manager. I am really needed this fix for our company and I can dot it, but I am not sure about my vision of the fix. I have the questions:

1. Should I save old logic to store credentials as plain text in gitextensions.config (it requres to add new checkbox)?
2. Can I disable distributed settings logic for credentials? I can save credentials using Credential manager, but they cannot be distributed and saved inside repository, because we cannot share credentials from credential manager.

[RussKie]

I would deprecate the old insecure storage mechanism and replace it with a secure store. It may be a little inconvenient for a user to re-enter username/password, but it is a small price to pay for security.

It is a good idea to lock username/password persistence to the local config only to prevent accidental sharing of secrets.

[pmiossec]

I did this proof of concept some times ago to store passwords in the credential manager. I don't know if it could help you: https://github.com/pmiossec/gitextensions/tree/passwords_in_credential_manager

[ghost]

Philippe, thanks. My prototype is the same :-). I will try to find free time to end the fix.

[pmiossec]

My prototype is the same :-). I will try to find free time to end the fix.

If you planned to fix it, you surely should create the pull request now.
Just prefix the title with "WIP:" until it's not finished.