Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is there a bug in RevisionGraph.ProccessGitLog? #4516

Closed
drewnoakes opened this issue Feb 23, 2018 · 2 comments
Closed

Is there a bug in RevisionGraph.ProccessGitLog? #4516

drewnoakes opened this issue Feb 23, 2018 · 2 comments
Assignees
@drewnoakes
Labels
type: bug 🐛
Milestone
3.00-beta1

Comments

@drewnoakes
Copy link
Member

On current master see RevisionGraph.ProccessGitLog line 169:

https://github.com/gitextensions/gitextensions/blob/master/GitCommands/RevisionGraph.cs#L169

It appears as though the string assignment should be a string append. That is,

// before
logParam = " --branches";

// after
logParam += " --branches";

If this is intentional, let's add some documentation to that effect.
@gerhardol
Copy link
Member

That is a bug that has been around since 2013 it seems.

The effect is thar git-log --branches cannot be used with date order or showing reflogs, so no catastrophe.

@drewnoakes
Copy link
Member Author

Cheers for confirming. Will put up a PR. Might also change it to use StringBuilder in the process to reduce allocations.

drewnoakes added a commit to drewnoakes/gitextensions that referenced this issue Feb 24, 2018
@drewnoakes
Fix git log parameter construction (fixes gitextensions#4516)
648819c 
The effect of this bug was that `git-log --branches` could not be used
with date order or showing reflogs.
@drewnoakes drewnoakes mentioned this issue Feb 24, 2018
Merged
@gerhardol gerhardol added this to the 3.00 milestone Feb 24, 2018
gerhardol pushed a commit that referenced this issue Feb 25, 2018
@drewnoakes @gerhardol
Fix git log command arguments and reduce allocations (#4519)
3823406 
* Fix `git log` parameter construction (fixes #4516)

The effect of this bug was that `git-log --branches` could not be used
with date order or showing reflogs.

* Make strings constant

* Use StringBuilder for logParams

* Use HasFlag

* String format items in increasing order

* Produce git log arguments with no temporaries

* Fix bug in branch filtering for `git log` command
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@drewnoakes drewnoakes

Labels
type: bug 🐛
Projects
None yet
Milestone
3.00-beta1
Development

No branches or pull requests
2 participants
@drewnoakes @gerhardol