Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List of submodule changes in CommitForm broken #4684

Closed
minj opened this issue Mar 21, 2018 · 6 comments
Closed

List of submodule changes in CommitForm broken #4684

minj opened this issue Mar 21, 2018 · 6 comments
Labels
type: bug 🐛
Milestone
3.00-beta1

Comments

@minj
Copy link

minj commented Mar 21, 2018

https://github.com/gitextensions/gitextensions/blob/master/GitUI/CommandsDialogs/FormCommit.cs#L2095

This assumes diff.submodule is set to "short".

Please make it explicit by calling diff --submodule=short in the line above
@RussKie
Copy link
Member

RussKie commented Mar 21, 2018

Thank you for the submission.
However please use the template provided, it is there for a reason.

@minj
Copy link
Author

minj commented Mar 21, 2018

Sorry but I am using my mobile and the template seemed too much of a hassle for ansingle line change

@sharwell
Copy link
Member

@minj The file has changed since the time you submitted this issue. I would recommend you use the following feature of GitHub to ensure the context is not lost in references to code:

image

@minj
Copy link
Author

minj commented Mar 28, 2018 •
edited

Not really, it hasn't.. that much:

https://github.com/gitextensions/gitextensions/blob/fb7b987690ff80d21e048a0eadea22d67d661728/GitUI/CommandsDialogs/FormCommit.cs#L2096,L2099

minj added a commit to minj/gitextensions that referenced this issue Sep 23, 2018
@minj
prevent crashes in generateListOfChangesInSubmodulesChangesToolStripM…
1917c2d 
…enuItem_Click

sets diff.submodule=short explicitly which may not match repo config

fixes gitextensions#4684
@minj minj mentioned this issue Sep 23, 2018
Closed
@RussKie
Copy link
Member

RussKie commented Nov 12, 2018

@gerhardol @vbjay is this something quick to fix?

@RussKie
Copy link
Member

RussKie commented Nov 12, 2018

Ignore this, it has been fixed.

@RussKie RussKie closed this as completed Nov 12, 2018
@RussKie RussKie added this to the 3.00-beta1 milestone Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug 🐛
Projects
None yet
Milestone
3.00-beta1
Development

No branches or pull requests
3 participants
@minj @sharwell @RussKie