Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LeftPanel - RepoObjectsTree._branchCriterionAutoCompletionSrc #4828

Closed
jbialobr opened this issue Apr 12, 2018 · 0 comments
Closed

LeftPanel - RepoObjectsTree._branchCriterionAutoCompletionSrc #4828

jbialobr opened this issue Apr 12, 2018 · 0 comments
Assignees
@jbialobr
Labels
area: left-panel Issues related to the Left Panel type: bug 馃悰
Milestone
3.00-beta1

Comments

@jbialobr
Copy link
Member

jbialobr commented Apr 12, 2018 •
edited by RussKie

Do you want to request a feature or report a bug?

馃悰

What is the current behavior?

RepoObjectsTree._branchCriterionAutoCompletionSrc is accessed from background threads, but is not thread safe.

What is the expected behavior?

I want to change it to be computed from tree nodes on demand on main thread.

/cc: @EbenZhang
@jbialobr jbialobr self-assigned this Apr 12, 2018
jbialobr added a commit to jbialobr/gitextensions that referenced this issue Apr 13, 2018
@jbialobr
Compute filter candidates on demand. Fixes gitextensions#4828.
4744df6
jbialobr added a commit to jbialobr/gitextensions that referenced this issue Apr 13, 2018
@jbialobr
Compute filter candidates on demand. Fixes gitextensions#4828.
0612a3a
jbialobr added a commit to jbialobr/gitextensions that referenced this issue Apr 13, 2018
@jbialobr
Compute filter candidates on demand. Fixes gitextensions#4828.
f9665aa
@jbialobr jbialobr mentioned this issue Apr 13, 2018
Merged
@RussKie RussKie added the area: left-panel Issues related to the Left Panel label Apr 14, 2018
@RussKie RussKie added this to the 3.00 milestone Apr 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jbialobr jbialobr

Labels
area: left-panel Issues related to the Left Panel type: bug 馃悰
Projects
None yet
Milestone
3.00-beta1
Development

No branches or pull requests
2 participants
@jbialobr @RussKie