Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some default settings should be changed #5030

Closed
pmiossec opened this issue Jun 5, 2018 · 16 comments
Closed

Some default settings should be changed #5030

pmiossec opened this issue Jun 5, 2018 · 16 comments

Comments

@pmiossec
Copy link
Member

pmiossec commented Jun 5, 2018

There are some settings that I think that the default value is not well chosen.
And to improve the discoverability and because that's easier to disable a feature than enabling it because we don't know it exists, I think that the default value should be changed.

I could think about 3 at the moment.

  • "Mark ill formed lines" in the commit form (commit message field) to turn it on by default. To enforce good git convention message (very few are aware of the good convention)
  • "Show SHA-1" in the revision grid (I show it multiple times and devs found it very convenient once they know it ;) )
  • "Show indicator for multiline message" in the revision grid

What do you think about?
Are there others?

@pmiossec
Copy link
Member Author

pmiossec commented Jun 5, 2018

That's not really linked to that but since we discuss about it...

What do you think about displaying only the abbreviated sha1 in the revision grid?

@drewnoakes
Copy link
Member

I like all of these proposals and will keep an eye out for other defaults we may like to change.

Can you move the idea about abbreviated SHA-1 in the grid to a new issue please? It would likely be a separate PR to one about default settings.

What's required to reset my settings to factory defaults? I'd like to share the unboxing experience.

@drewnoakes drewnoakes changed the title [Discussion] Values of some default settings Some default settings should be changed Jun 5, 2018
@jbialobr
Copy link
Member

jbialobr commented Jun 5, 2018

Are there others?

I would turn on by default the Show reflog references option.

@drewnoakes
Copy link
Member

"Show relative date" seems quite nice.

@drewnoakes drewnoakes added up-for-grabs Easy tasks for those looking to get involved. Refer to https://up-for-grabs.net/ 🤓 good first issue labels Jun 5, 2018
@gerhardol
Copy link
Member

What do you think about displaying only the abbreviated sha1 in the revision grid?
Show SHA-1" in the revision grid (I show it multiple times and devs found it very convenient once they know it ;) )

Show abrivated in list, copy full?

"Show relative date" seems quite nice.

No, you loose the precision

@pmiossec
Copy link
Member Author

pmiossec commented Jun 5, 2018

I would turn on by default the Show reflog references option.

@jbialobr Are you sure that's a good idea? This option is more to rescue lost commits and could make the display cumbersome when doing some rebase/amend. I'm afraid that the beginners won't understand why there are commits dangling like that...

"Show relative date" seems quite nice.

I'm pretty sure that it's the default to display date as relative. Because I don't like that option and that's one of the first disable when using a new computer... But I don't want to enforce my choice on this one because I don't know if it's just a matter of taste or if there is a real value to use on format more than the other. I let you choose about this one...

@vbjay
Copy link
Contributor

vbjay commented Jun 5, 2018 via email

@pmiossec
Copy link
Member Author

pmiossec commented Jun 5, 2018

Doesn't git already give you the shortest it can tray is unique. Shortest is still variable length.

No. there is an option of the git log command to get the abbreviated sha1

@vbjay
Copy link
Contributor

vbjay commented Jun 5, 2018 via email

@vbjay
Copy link
Contributor

vbjay commented Jun 5, 2018 via email

@RussKie
Copy link
Member

RussKie commented Jun 5, 2018 via email

@pmiossec
Copy link
Member Author

pmiossec commented Jun 5, 2018

let's continue the discussion about the short sha1 in #5032

@pmiossec
Copy link
Member Author

pmiossec commented Jun 5, 2018

I believe "relative dates" is on by default. I don't mind it personally.

same for me...

@WildBamboo
Copy link

I'm not sure if this is considered a "default setting" or not, but I would very much appreciate it if after every upgrade Git Extensions does NOT adjust or add a default editor to my .gitconfig file.

@RussKie
Copy link
Member

RussKie commented Jun 8, 2018 via email

@drewnoakes
Copy link
Member

Can we close this?

@drewnoakes drewnoakes added this to the 3.00 milestone Jun 13, 2018
@RussKie RussKie closed this as completed Jun 16, 2018
@RussKie RussKie added type: feature request and removed 🤓 good first issue up-for-grabs Easy tasks for those looking to get involved. Refer to https://up-for-grabs.net/ labels Jun 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants