Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RevisionGrid Graph: Show more informative tooltips #5125

Closed
mstv opened this issue Jun 28, 2018 · 4 comments
Closed

RevisionGrid Graph: Show more informative tooltips #5125

mstv opened this issue Jun 28, 2018 · 4 comments

Comments

@mstv
Copy link
Member

mstv commented Jun 28, 2018

Do you want to request a feature or report a bug?

feature

What is the current behavior?

tooltip with commit hash of wrong lane
grafik

What is the expected behavior?

commit hash, [later: branches contained in / being at] and commit heading of lane under mouse
grafik
grafik
grafik

Environment you encounter the issue:

  • GitExtensions version: v3-ux, master
  • GIT version: N/A (2.17.windows.2)
  • OS version: N/A (Windows 7)
  • .NET version: N/A

Did this work in previous version of GitExtensions (which)?

PR #5017 but with high load by firing git.exe for display of branch info

@gerhardol
Copy link
Member

When hovering the branches, I expect to see branch information, probably tags too. (not like this in v3-ux branch)

When hovering the commit headline I expect to get a tooltip also when there is a one line message (especially when branch tags are replacing the message).

@mstv
Copy link
Member Author

mstv commented Jul 2, 2018

When hovering the branches, I expect to see branch information, probably tags too. (not like this in v3-ux branch)

I agree, the whole commit message seems to be too much.
I would prefer "committed to branch xy". But Git does not store this information by design.
Retrieving the same branch information as for the Commit Info, proved to be too expensive (causing too much load by firing git.exe).
The information on branches (and tags) can be extracted from the graph's nodes and junctions (without firing git.exe). But this will take a while to implement. That's why I wrote "later" above.
Which branches should be selected for display in the tooltip? In which order should they be listed?

When hovering the commit headline I expect to get a tooltip also when there is a one line message (especially when branch tags are replacing the message).

I get such a tooltip when the message is truncated.

@pmme
Copy link
Contributor

pmme commented Jul 3, 2018

I believe the resolution for this issue will resolve #4450

drewnoakes pushed a commit to drewnoakes/gitextensions that referenced this issue Jul 3, 2018
@gerhardol
Copy link
Member

Branch lane is low prio and later as you wrote. Just a clean view with commit is OK for me.
I would like to have this as the overflow area for all branch heads and tags, as some may not be visible on the message line. Other than that, the info in the commit tab would be good. But do not slow down normal operation.

For commit message, I suggest the message is displayed for consistency. Otherwise you might wonder why youget tool tip for some lines and not for others.

drewnoakes pushed a commit to drewnoakes/gitextensions that referenced this issue Jul 4, 2018
drewnoakes pushed a commit to drewnoakes/gitextensions that referenced this issue Jul 8, 2018
drewnoakes pushed a commit to drewnoakes/gitextensions that referenced this issue Jul 8, 2018
drewnoakes pushed a commit to drewnoakes/gitextensions that referenced this issue Jul 9, 2018
drewnoakes pushed a commit to drewnoakes/gitextensions that referenced this issue Jul 12, 2018
drewnoakes pushed a commit to drewnoakes/gitextensions that referenced this issue Jul 22, 2018
mstv added a commit to mstv/gitextensions that referenced this issue Sep 9, 2018
mstv added a commit to mstv/gitextensions that referenced this issue Sep 9, 2018
mstv added a commit to mstv/gitextensions that referenced this issue Sep 15, 2018
mstv added a commit to mstv/gitextensions that referenced this issue Sep 15, 2018
gerhardol pushed a commit to gerhardol/gitextensions that referenced this issue Sep 17, 2018
gerhardol pushed a commit to gerhardol/gitextensions that referenced this issue Sep 23, 2018
mstv added a commit to mstv/gitextensions that referenced this issue Sep 24, 2018
gerhardol pushed a commit to gerhardol/gitextensions that referenced this issue Sep 24, 2018
gerhardol pushed a commit to gerhardol/gitextensions that referenced this issue Sep 26, 2018
gerhardol pushed a commit to gerhardol/gitextensions that referenced this issue Sep 26, 2018
mstv added a commit to mstv/gitextensions that referenced this issue Oct 20, 2018
mstv added a commit to mstv/gitextensions that referenced this issue Oct 23, 2018
mstv added a commit to mstv/gitextensions that referenced this issue Oct 29, 2018
…f 3)

Factor out LaneInfoProvider and LaneNodeLocator
Reference identical version 4.5.0 of System.ValueTuple
Limit tooltips to 30 lines
@ghost ghost added the waffle:needs review label Oct 29, 2018
mstv added a commit to mstv/gitextensions that referenced this issue Oct 29, 2018
…of 3)

Adapt and activate BranchFinder
Solve regression in LaneNodeLocator
mstv added a commit to mstv/gitextensions that referenced this issue Oct 30, 2018
…of 3)

Keep order of branches to make BranchFinder work correctly again
mstv added a commit to mstv/gitextensions that referenced this issue Oct 31, 2018
mstv added a commit to mstv/gitextensions that referenced this issue Oct 31, 2018
…of 3a-c)

Extract new interface IRevisionGraphRow
Adapt LaneNodeLocatorTests
mstv added a commit to mstv/gitextensions that referenced this issue Oct 31, 2018
…of 3a-c)

Extract new interface IRevisionGraphRow
Adapt LaneNodeLocatorTests
mstv added a commit to mstv/gitextensions that referenced this issue Oct 31, 2018
…of 3a-c)

Adapt LaneInfoProviderTests.cs
Use RevisionGraphRevision.Parents instead of .StartSegments
mstv added a commit to mstv/gitextensions that referenced this issue Nov 14, 2018
mstv added a commit to mstv/gitextensions that referenced this issue Nov 14, 2018
mstv added a commit to mstv/gitextensions that referenced this issue Dec 18, 2018
mstv added a commit to mstv/gitextensions that referenced this issue Jan 2, 2019
RussKie added a commit that referenced this issue Jan 3, 2019
…ltip_2

#5125 RevisionGrid Graph: Nearest branch in tooltip
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants