Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore revision grid highlighting of commits by author #5197

Closed
RussKie opened this issue Jul 24, 2018 · 8 comments
Closed

Restore revision grid highlighting of commits by author #5197

RussKie opened this issue Jul 24, 2018 · 8 comments
Assignees
Labels
area: user experience type: regression regression, normally to latest official release
Milestone

Comments

@RussKie
Copy link
Member

RussKie commented Jul 24, 2018

Do you want to request a feature or report a bug?
Regression from #5087

What is the current behavior?
The highlighting for commits from the same author has been removed as part of the uplift, and replaced with author column highlighting.

What is the expected behavior?
Highlighting should be configurable.

Environment you encounter the issue:

Did this work in previous version of GitExtensions (which)?
Yes, 2.51

@RussKie RussKie added area: user experience type: regression regression, normally to latest official release labels Jul 24, 2018
@drewnoakes
Copy link
Member

drewnoakes commented Jul 24, 2018

As discussed in #5087 I like the idea of a general approach to revision highlighting in the grid.

To that end, I would vote for highlighting a given author's commits when the author's name cell is clicked. Ctrl+click to highlight additional authors.

Other forms of highlighting:

  • Commits that modify a given file/folder (gitk does this and it's great)
  • Commits on a given branch (parallel to current greying out of graph nodes/lines not on a given branch currently available via menus or Ctrl+Shift+B)
  • Others?

@RussKie if you feel this would be appropriate, perhaps we could avoid adding another setting. I don't really use author highlighting so can't tell whether this would scratch your itch.

@gerhardol
Copy link
Member

I use author highlightning, but actually come to prefer the bold text over the row coloring.
So this is no regression for me. But this is to agree on! (RussKie has most votes anyway.)

Configurability is a new feature, I like to track a certain file.

@pmiossec
Copy link
Member

I also would like this feature reintroduced.

I don't use it a lot but the first time I used it with the new commiter highlight in bold, I found it less usable (you have to look at 2 columns at the same time : commiter and commit message.)

But if we end up with an even better highlight of commit, I take it 😁

I particularly love the idea to be able to highlight commits with changes on a specific file. It would be great 👍

@RussKie
Copy link
Member Author

RussKie commented Jul 26, 2018

@drewnoakes yes, the highlighting makes my life significantly easier, especially on large monitors.
I like your other proposals, I think they are great.

RussKie has most votes anyway

I'd like to think of us as a "republic", so we're all have the same weight.

@mdonatas
Copy link
Contributor

I so +1 this! Devs in our team use this feature when billing hours. You click one of your commits and read commit messages under yellow background to remind yourself of what you worked on.
Or, to quickly see what say a front-end designer did, etc. Having to look at two columns with a BIG gap between them is totally unworkable.

Can we limit this issue to first bringing the background highlight back?

Also, @drewnoakes these highlight options, where would they be chosen? When say right-clicking a revision grid?

@crypto-rsa
Copy link
Contributor

Devs in our team use this feature when billing hours.

@mdonatas to this end I have a simple git alias:

[alias]
	week = log --author=\"Pavel\" --since=\"last Sunday\" --all --reverse --oneline --no-merges

So at the end of the week I just run git week 😄 Of course that doesn't mean a highlighting feature in GE would not be useful.

@RussKie RussKie pinned this issue Dec 18, 2018
RussKie added a commit to RussKie/gitextensions that referenced this issue Dec 24, 2018
@ghost ghost assigned RussKie Dec 24, 2018
@ghost ghost added the status: ready label Dec 24, 2018
RussKie added a commit to RussKie/gitextensions that referenced this issue Dec 27, 2018
@RussKie RussKie modified the milestones: 3.1.0, 3.0.1 Dec 27, 2018
@RussKie
Copy link
Member Author

RussKie commented Dec 27, 2018

To that end, I would vote for highlighting a given author's commits when the author's name cell is clicked. Ctrl+click to highlight additional authors.

Other forms of highlighting:

  • Commits that modify a given file/folder (gitk does this and it's great)
  • Commits on a given branch (parallel to current greying out of graph nodes/lines not on a given branch currently available via menus or Ctrl+Shift+B)
  • Others?

I'm restoring the highlight as we had it in 2.5x, as for me it is a UX regression.
That said, I quite like the above proposals and I'm quite interested in further discussions how we can implement these.

@ghost ghost removed the status: ready label Dec 29, 2018
RussKie added a commit that referenced this issue Dec 29, 2018
Closes #5197

(cherry picked from commit 89201d6)
@mdonatas
Copy link
Contributor

😍😍😍❤❤💕💕💕💖💖💖✔

@gerhardol gerhardol unpinned this issue Dec 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: user experience type: regression regression, normally to latest official release
Projects
None yet
Development

No branches or pull requests

6 participants