Avatars makes app unresponsive on slow internet connection

[patrikturi]

Do you want to request a feature or report a bug?
Bug

What is the current behavior?
When I open a repository in GitExtensions with gitex.cmd sometimes the window goes to "not responding" for 15-30 seconds. It does now always happen. I've checked it and git commands take below 100ms and CPU usage is low. Also I noticed that if it is a freshly cloned repository, it greatly increases the chance of this bug happening (new repo about 30%, old repo just 5%). Killing the window and re-opening will get "not responding" again. However, if I wait until the "not responding" phase is done, re-opening the same repo is fine, the bug does not happen.
There is no other GitExtensions instance open when the issue happens.

Environment you encounter the issue:

• GitExtensions version: 2.51.04
• GIT version: git version 2.18.0.windows.1 (most likely irrelevant)
• OS version: both Win7 and Win10
• .NET version:

Did this work in previous version of GitExtensions (which)?
I think last version I tried without this bug was 2.49.03. After 2.50.0 I was constantly updating hoping it is fixed but it was not.

[vbjay]

Run this in git bash in the folder where the repo is located.

git count-objects -v -H >before.txt
git gc --aggressive
git count-objects -v -H >after.txt  
cat before.txt after.txt >full.txt

Show the contents of the full.txt file.

[RussKie]

Could you post the timings from gitcommand log (Tools > Gitcommand log)?

Do you have an antivirus that may be interfering?

[patrikturi]

I have used 2.49.03 for a week and zero issues. Same git, same windows, same anti virus (Symantec).

Now I have switched back to 2.51.04 and the issue popped up after some hours again.

Here is the Command log after the issue happened:

@vbjay
I tried but if I do your commands after the issue happened, it shows no difference. If I clone the project again, then the "Not responding" issue does not happen. Sorry I think I was wrong that it happens more often with fresh repositories, it happens just as well with existing ones.

[RussKie]

Nothing in your log looks out of ordinary, timings are in hundreds of ms

[vbjay]

Try turning off your antivirus. Load a repo. Let us know the results. 95% of the time it's antivirus.

…

On Thu, Aug 30, 2018, 8:34 AM RussKie ***@***.***> wrote: Nothing in your log looks out of ordinary, timings are in hundreds of ms — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5309 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADdhsVPrPc19YvTD32F7ONCM6HtPvPd3ks5uV9vWgaJpZM4V4WqE> .

[RussKie]

Does this problem affect all repos?
Do they have submodules?

[patrikturi]

Turned off antivirus, it happened again. And it does not happen with 2.49.03 and antivirus.

I don't use any submodules.
It seems to affect all repos, as the occurence seems to be random.

[vbjay]

Show your git config -l results.

…

On Thu, Aug 30, 2018 at 12:08 PM Túri Patrik ***@***.***> wrote: Turned off antivirus, it happened again. And it does not happen with 2.49.03 and antivirus. I don't use any submodules. It seems to affect all repos, as the occurence seems to be random. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5309 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADdhsf0jd0lb7_cM3jLjfp3r6nw914jIks5uWA3tgaJpZM4V4WqE> .

[patrikturi]

Now I have experienced it happens when I click on the commit of a new person for the very first time, and also happens after I do a "Clear image cache" and restart GitExtensions.

I was using the Identicon image service, now I have set the image service to None but the issue is still there. Any tips how to disable this feature completely? Because now that I have set it to None most people are shown black, but a for few who have uploaded a picture, that picture is still shown to me after clearing the cache.

[RussKie]

Images are stored under C:\Users\<user>\AppData\Roaming\GitExtensions\GitExtensions\Images.
Clear image cache option will delete all images from that folder.

No image service is a flag to tell avatar resolution service that if avatar can't be found, use the default one (the None option). Other options (Identicon et al) will hit gravatar.com to source images.

[patrikturi]

I believe it is caused by using GitExtensions -> Settings -> Appearance -> Get author image from gravatar.com with a slow internet connection.
I have set it to No and didn't happen today, I will check back a week later.

[patrikturi]

I had gravatar turned off all week and zero issues, so that is it.

[drewnoakes]

This should definitely not be blocking the UI.

[gerhardol]

A change related to this is done in #5878, planned for 3.0.1

[drewnoakes]

See also #5859.

[RussKie]

Fixed in #6287