Commit dialog: retain the view position when updating the diff

[mstv]

Do you want to request a feature or report a bug?
incomplete new feature

What is the current behavior?
The commit dialog refreshes automatically when GE gets the focus again since v3-ux.
The cursor/scroll position is reset to the top of the diff.

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem.
Open the commit dialog with a diff (regardless staged or unstaged), scroll down the diff, switch to an other application, switch back to GE.

What is the expected behavior?
The view position shall be restored after reloading the diff.
This should be tried, too, when the display options are changed using .

If the cursor position was visible before, it should be restored.
If not, the previous top or the middle line shoud be restored.

Environment you encounter the issue:

• GitExtensions version: master
• GIT version: 2.17.1.w.2-x64
• OS version: Windows 7
• .NET version: 4.7

Did this work in previous version of GitExtensions (which)?
2.5

[vbjay]

Click options in the commit window.

…

On Sun, Aug 19, 2018, 6:45 PM Michael Seibt ***@***.***> wrote: *Do you want to request a feature or report a bug?* incomplete new feature *What is the current behavior?* The commit dialog refreshes automatically when GE gets the focus again since v3-ux. The cursor/scroll position is reset to the top of the diff. *If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem.* Open the commit dialog with a diff (regardless staged or unstaged), scroll down the diff, switch to an other application, switch back to GE. *What is the expected behavior?* The view position shall be restored after reloading the diff. This should be tried, too, when the display options are changed using [image: grafik] <https://user-images.githubusercontent.com/36601201/44313914-0334ee80-a411-11e8-9594-e5efcd916435.png> . If the cursor position was visible before, it should be restored. If not, the previous top or the middle line shoud be restored. *Environment you encounter the issue:* - GitExtensions version: master - GIT version: 2.17.1.w.2-x64 - OS version: Windows 7 - .NET version: 4.7 *Did this work in previous version of GitExtensions (which)?* 2.5 — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#5327>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADdhsVzC1qWSo-HVXES9prrh_fsXRmktks5uSeqLgaJpZM4WDJlU> .

[mstv]

I appreciate the automatic update in general. But the current behavior annoys me and will do for others which don't know that it can be turned off.

You can consider it a new feature regarding switching on/off the display of the entire file.
As side effect, its implementation will improve the ux with automatic update enabled significantly (at least for me).