Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search settings should expand the whole tree #5341

Closed
mstv opened this issue Aug 22, 2018 · 1 comment
Closed

Search settings should expand the whole tree #5341

mstv opened this issue Aug 22, 2018 · 1 comment

Comments

@mstv
Copy link
Member

mstv commented Aug 22, 2018

Do you want to request a feature or report a bug?
feature

What is the current behavior?
It seems that no setting has been found if the search string appears on nested pages only:
grafik

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem.

  • open Tools | Settings
  • type "multi" as text to find

What is the expected behavior?
The whole settings tree should be expanded in order to see which pages contain the search string.
(This is important because the search string is cleared when the search field loses the focus.)
The first settings page containing the search string should be shown.
grafik

Environment you encounter the issue:

  • GitExtensions version: master
  • GIT version: (2.17.1.w.2-x64)
  • OS version: (Windows 7)
  • .NET version: (4.7)

Did this work in previous version of GitExtensions (which)?
Not in 2.51.02 which shows the number of hits at least.

@RussKie
Copy link
Member

RussKie commented Aug 24, 2018

This is important because the search string is cleared when the search field loses the focus.

Perhaps we should be doing this

@RussKie RussKie added type: bug 🐛 up-for-grabs Easy tasks for those looking to get involved. Refer to https://up-for-grabs.net/ 🤓 good first issue labels Aug 24, 2018
mstv added a commit to mstv/gitextensions that referenced this issue Sep 17, 2018
mstv added a commit to mstv/gitextensions that referenced this issue Sep 19, 2018
@RussKie RussKie removed 🤓 good first issue up-for-grabs Easy tasks for those looking to get involved. Refer to https://up-for-grabs.net/ labels Sep 19, 2018
@RussKie RussKie added this to the 3.00 milestone Sep 19, 2018
@RussKie RussKie modified the milestones: 3.00, 3.00-beta2 Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants