Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl+T for Create tag form picks checked out revision rather than active one #5564

Closed
mdonatas opened this issue Oct 15, 2018 · 3 comments
Closed
Assignees
Labels
type: bug 🐛 type: regression regression, normally to latest official release
Milestone

Comments

@mdonatas
Copy link
Contributor

Do you want to request a feature or report a bug?
Hard to tell.

What is the current behavior?
Ctrl+T opens Create tag form with revision set to currently checked revision.

What is the expected behavior?
Ctrl+B for Create branch form picks revision based on currently selected revision. I find this a lot more sensible. Suggestion is to do the same for Create tag form i.e. pick revision based on what's selected in revision grid.

@RussKie
Copy link
Member

RussKie commented Oct 15, 2018

It sounds like a regression, in 2.5x the tag is being created at the selected commit, not at the checked out one

@mdonatas
Copy link
Contributor Author

I'll fix it, this has bitten me in the rear far too many times in recent weeks.

@gerhardol gerhardol added type: bug 🐛 type: regression regression, normally to latest official release and removed 👓 status: needs review labels Oct 15, 2018
@gerhardol
Copy link
Member

Confirmed, assigned to @mdonatas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 type: regression regression, normally to latest official release
Projects
None yet
Development

No branches or pull requests

3 participants