Git version check is removed

[gerhardol]

Do you want to request a feature or report a bug?
bug

What is the current behavior?
The Git version check is lost

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem.
The settings have been split, separating GE and Git. The Git version check for minimum and recommended Git version was then removed.

In 2.x

3.0

What is the expected behavior?
GE checks Git in the Settings

Environment you encounter the issue:

• Git Extensions 3.00.00.02-rc1
• 7990325 (Dirty)
• Git 2.19.1.windows.1
• Microsoft Windows NT 10.0.17134.0
• .NET Framework 4.7.3190.0

Did this work in previous version of GitExtensions (which)?
yes, master before split (in August?)

[RussKie]

Hmm, how did this happen?

…

On Mon, 5 Nov 2018 at 07:06, Gerhard Olsson ***@***.***> wrote: *Do you want to request a feature or report a bug?* bug *What is the current behavior?* The Git version check is lost *If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem.* The settings have been split, separating GE and Git. The Git version check for minimum and recommended Git version was then removed. In 2.x [image: image] <https://user-images.githubusercontent.com/6248932/47969256-1a30c780-e075-11e8-9c7c-cb5059891109.png> 3.0 [image: image] <https://user-images.githubusercontent.com/6248932/47969260-36ccff80-e075-11e8-9f5b-83cf6c19b67c.png> *What is the expected behavior?* GE checks Git at startup and in the Settings *Environment you encounter the issue:* - Git Extensions 3.00.00.02-rc1 - 7990325 <7990325> (Dirty) - Git 2.19.1.windows.1 - Microsoft Windows NT 10.0.17134.0 - .NET Framework 4.7.3190.0 *Did this work in previous version of GitExtensions (which)?* yes, master before split (in August?) — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#5695>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEMyXvZodAV911x1GxK--08nQeMo3PaSks5ur0jcgaJpZM4YNe0I> .

[gerhardol]

This was changed in fd51228 #5132
When GitCredentialWinStire check was added, Git version was removed
(This was done in a refactor after reviews.)

GitUI\CommandsDialogs\SettingsDialog\Pages\ChecklistSettingsPage.cs
CheckSettings() does not call CheckGitCmdValid();

Will submit PR

[gerhardol]

Note: GE do not warn for unsupported versions (as well as not recommended) at startup, just if Git is available.