Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitFlow - Finish not working #5912

Closed
Toudahl opened this issue Dec 14, 2018 · 8 comments
Closed

GitFlow - Finish not working #5912

Toudahl opened this issue Dec 14, 2018 · 8 comments

Comments

@Toudahl
Copy link

Toudahl commented Dec 14, 2018

Do you want to request a feature or report a bug?
Bug
What is the current behavior?
Git flow command is not executed correctly. It only runs: Git flow

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem.
Make a git-flow branch, e.g. a feature branch. Commit some work, and try to finish this using the menus in git extensions
https://github.com/Toudahl/git-flow-bug

What is the expected behavior?
The finish button should do: git flow feature finish MYFEATURE
Environment you encounter the issue:

  • Git Extensions 3.00.00.4433
  • Build fca7cf2
  • Git 2.20.0.windows.1
  • Microsoft Windows NT 10.0.17134.0
  • .NET Framework 4.7.3221.0
  • DPI 96dpi (no scaling)

Did this work in previous version of GitExtensions (which)?
Yes. Every single one.

@gerhardol gerhardol added type: bug 🐛 area: plugins up-for-grabs Easy tasks for those looking to get involved. Refer to https://up-for-grabs.net/ labels Dec 14, 2018
@gerhardol
Copy link
Member

Should be fixed by someone that uses Git Flow (not added to any milestone)

@drewnoakes
Copy link
Member

@Toudahl would you be able to debug this? None of the maintainers use git flow. You're in a great position to investigate the problem. If you need help, we'll be happy to give it.

@Toudahl
Copy link
Author

Toudahl commented Dec 14, 2018

Yes. But we have a Christmas party this weekend, so it will probably not be able to look at it this week

@Toudahl
Copy link
Author

Toudahl commented Dec 14, 2018

This issue is already fixed in 2d66428 and merged into the master branch.

The version of gitextensions that gitext offers to download (currently the latest available), has the bug. But 3.01.00.0

Related issue: #5893

@Toudahl Toudahl closed this as completed Dec 14, 2018
@drewnoakes
Copy link
Member

Thank you for following up @Toudahl. Feel free to dive into something else if the urge takes you. Maybe review the "good first issue" label: https://github.com/gitextensions/gitextensions/labels/good%20first%20issue

@drewnoakes drewnoakes removed the up-for-grabs Easy tasks for those looking to get involved. Refer to https://up-for-grabs.net/ label Dec 14, 2018
@griiid
Copy link

griiid commented Jan 19, 2019

Sorry, I'm new to git extensions, fount that git flow feature finish dosen't work, too, in version 3.00.00.4433.

I saw this issue was closed, and Toudahl said the bug was fixed in version 3.01.00.0.

I downloaded git extensions from sourceforge.net, and there's no update when I clicked Check for updates.

Also, I can't find the new version in release, can you tell me where can I get the new version?

@vbjay
Copy link
Contributor

vbjay commented Jan 19, 2019

That's because it hasn't been released.

@ghost
Copy link

ghost commented Jan 19, 2019

@griiid : That also means you need either to download Git Extensions 3.01.00 from one of the artifacts produced by AppVeyor, or compile it yourself from the source code, if you want to use version 3.01.00 before it is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants