Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitFlow plugins Finish button doesn't work fine #5893

Closed
Fabman08 opened this issue Dec 12, 2018 · 0 comments · Fixed by #5894
Closed

GitFlow plugins Finish button doesn't work fine #5893

Fabman08 opened this issue Dec 12, 2018 · 0 comments · Fixed by #5894
Labels
area: plugins type: bug 🐛
Milestone
3.0.1

Comments

@Fabman08
Copy link
Contributor

Do you want to request a feature or report a bug?
BUG

What is the current behavior?
Plugins => GitFlow
Pressing Finish Button raises an error of git flow command

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem.
Plugins => GitFlow => Select a branch to be finished => click Finish Button

What is the expected behavior?
Merge the branch selected into develop/master branch

Environment you encounter the issue:
See below :)

  • Git Extensions 3.00.00.4433
  • Build fca7cf2
  • Git 2.20.0.windows.1
  • Microsoft Windows NT 10.0.17134.0
  • .NET Framework 4.7.3221.0
  • DPI 96dpi (no scaling)

Did this work in previous version of GitExtensions (which)?
Yes, it works on 2.59

Probably the issue is due to

gitextensions/Plugins/GitFlow/GitFlowForm.cs
line 293

Thank you!
@RussKie RussKie added type: bug 🐛 area: plugins :neckbeard: status: pull request only Requested changes won't be implemented by the Core team, community PRs are welcome up-for-grabs Easy tasks for those looking to get involved. Refer to https://up-for-grabs.net/ labels Dec 12, 2018
Fabman08 pushed a commit to Fabman08/gitextensions that referenced this issue Dec 12, 2018
Fix issue gitextensions#5893
2d66428
@Fabman08 Fabman08 mentioned this issue Dec 12, 2018
Merged
RussKie added a commit that referenced this issue Dec 12, 2018
@RussKie
Merge pull request #5894 from Fabman08/master
dd0bebc 
Fix issue #5893
@RussKie RussKie removed up-for-grabs Easy tasks for those looking to get involved. Refer to https://up-for-grabs.net/ :neckbeard: status: pull request only Requested changes won't be implemented by the Core team, community PRs are welcome labels Dec 12, 2018
@RussKie RussKie added this to the 3.0.1 milestone Dec 12, 2018
@Toudahl Toudahl mentioned this issue Dec 14, 2018
Closed
RussKie pushed a commit that referenced this issue Dec 21, 2018
@RussKie
Fix issue #5893
a79e836 
(cherry picked from commit 2d66428)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: plugins type: bug 🐛
Projects
None yet
Milestone
3.0.1
Development

Successfully merging a pull request may close this issue.

Fix issue #5893 Fabman08/gitextensions
2 participants
@RussKie @Fabman08