Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script: cDefaultRemotePathFromUrl returns bad information #5932

Closed
malys opened this issue Dec 17, 2018 · 3 comments · Fixed by #5942
Closed

Script: cDefaultRemotePathFromUrl returns bad information #5932

malys opened this issue Dec 17, 2018 · 3 comments · Fixed by #5942
Assignees
Labels
type: bug 🐛 type: regression regression, normally to latest official release
Milestone

Comments

@malys
Copy link

malys commented Dec 17, 2018

Hi,
Do you want to request a feature or report a bug?
I want to report a bug.

What is the current behavior?
{cDefaultRemotePathFromUrl} script tag returns always "git"

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem.
Create a script {openUrl} https://gitlab.com{cDefaultRemotePathFromUrl}/tree/{sBranch}
The script should return: https://gitlab.com/gitlabhq/gitlabhq/tree/master
where cDefaultRemotePathFromUrl=/gitlabhq/gitlabhq and sBranch=master

After upgrading cDefaultRemotePathFromUrl=git

See your provided script "Open on GitHub", It doesn't work fine.

Environment you encounter the issue:

  • Git Extensions 3.00.00.4433
  • Build fca7cf2
  • Git 2.20.1.windows.1
  • Microsoft Windows NT 10.0.17134.0
  • .NET Framework 4.7.3260.0
  • DPI 96dpi (no scaling)

Did this work in previous version of GitExtensions (which)?
It works well with previous version.

@RussKie
Copy link
Member

RussKie commented Dec 18, 2018

I believe the regression was introduced in 587af4f#diff-062fb32fceffaf338389dbd4d17fddcbR87

RussKie added a commit to RussKie/gitextensions that referenced this issue Dec 18, 2018
`{cDefaultRemotePathFromUrl}` script variable now resolves correctly.
Fixes gitextensions#5932
@ghost ghost assigned RussKie Dec 18, 2018
@ghost ghost added the status: ready label Dec 18, 2018
@RussKie
Copy link
Member

RussKie commented Dec 18, 2018

@RussKie RussKie added type: bug 🐛 type: regression regression, normally to latest official release labels Dec 18, 2018
@RussKie RussKie added this to the 3.0.1 milestone Dec 18, 2018
@malys
Copy link
Author

malys commented Dec 18, 2018

@RussKie Well done. The regression is fixed.
Thx for your help and reactivity.

@ghost ghost removed the status: ready label Dec 18, 2018
RussKie added a commit that referenced this issue Dec 21, 2018
`{cDefaultRemotePathFromUrl}` script variable now resolves correctly.
Fixes #5932
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 type: regression regression, normally to latest official release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants