Can no longer reset submodule changes in the super project's commit window.

[Tagette]

When I try to reset submodule changes from the super projects commit window, it does not reset anything.

1. Make changes in a child submodule.
2. Go to the super project's commit window.
3. Right click the submodule change and click "Reset submodule changes".
4. Notice how the changes were not reset.

This bug may require that you only have "new file" changes in the submodule.

• GitExtensions version: 3.00.00
• GIT version: 2.20.1
• OS version: Windows 10
• .NET version: Windows 10

This works in git extensions 2.51.05.

[vbjay]

Works

Works

Fails to delete new files even if Also delete new files checked

[vbjay]

Workaround is to select commit submodule changes and then in the new dialog, reset in the current dialog and then close the dialog. Then continue with main repo actions.

[gerhardol]

As vbjay showed, this only affects new files not being deleted. This occurred both in the Commit dialog and in revisiondiff (WorkingTree artificial commit).

Please test the updated build in https://ci.appveyor.com/project/gitextensions/gitextensions/builds/21261432

[RussKie]

Submodules reset/update has always left me utterly confused... Looking forward to a fix.

[gerhardol]

commit|reset|stash submodule changes
All are done in the context of the submodule, same as if you opened the submodule and applied the command there.

Update submodule is different, it is changing the commit from the current repo (superproject).
A separator could be added in the context menus.

[RussKie]

Indeed, however when I see a dirty state of a repo due to submodules I have to always think - do I need to update or reset or both? And I never seem to get it right /facepalm

…

On Fri, 28 Dec 2018 at 22:31, Gerhard Olsson ***@***.***> wrote: commit|reset|stash submodule changes All are done in the context of the submodule, same as if you opened the submodule and applied the command there. Update submodule is different, it is changing the commit from the current repo (superproject). A separator could be added in the context menus. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#5937 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEMyXgqzQABNfRCTFWLWn_IufcHuGSazks5u9gEtgaJpZM4ZXFJj> .

[vbjay]

We could use ahead/back status to tell the user they are on the same commit and there are changes in the working directory (0 ahead, 0 back). They can always get more details by right clicking and clicking commit submodule details. That tells you if there are working directory changes.