Crash when clicking on "Help translate" in appearance settings

[Kryptos-FR]

Do you want to request a feature or report a bug?
A bug.

What is the current behavior?
Clicking on "help translate" link in the Appearance section of the settings window crash the application.

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem.

1. Open the settings window
2. Go to Git Extensions -> Appearance section
   
3. Click on "Help translate"
4. GitExtensions crashes
   

What is the expected behavior?

• When developing GitExtensions it could open the TranslationApp (crashes because application doesn't exists)
• In official releases, it should go to the wiki page (same as Menu -> Help -> Translate)
• Should be surrounded by a try...catch in any case.

Environment you encounter the issue:

• Git Extensions 3.00.00.4433
• Build fca7cf2
• Git 2.19.1.windows.1
• Microsoft Windows NT 6.1.7601 Service Pack 1
• .NET Framework 4.7.3133.0
• DPI 96dpi (no scaling)

Did this work in previous version of GitExtensions (which)?
Dunno. Never tried before.

[drewnoakes]

@Kryptos-FR thank you for the report!

I can reproduce this.

(We really need to replace that useless NBug dialog with something that makes it easy for people to include meaningful information in issues...)

[drewnoakes]

The code in question is here:

gitextensions/GitUI/CommandsDialogs/SettingsDialog/Pages/AppearanceSettingsPage.cs

Lines 171 to 174 in 7211073

	private void helpTranslate_LinkClicked(object sender, LinkLabelLinkClickedEventArgs e)
	{
	Process.Start(Path.Combine(Path.GetDirectoryName(Application.ExecutablePath), "TranslationApp.exe"));
	}

Is this an omission of the installer? Are we supposed to be bundling TranslationApp.exe?

[gerhardol]

TranslationApp should not be included, only used by maintainers now. The link should be to the wiki page.

[RussKie]

(We really need to replace that useless NBug dialog with something that makes it easy for people to include meaningful information in issues...)

Yes, related discussion in #5064

Is this an omission of the installer? Are we supposed to be bundling TranslationApp.exe?

I suppose no one ever clicked the link until now... 🤦‍♂️

Instead of using the TranslationApp (which is only used for updating translations when prep'ing releases), this link should behave consistently with other "translate" links and navigate to https://github.com/gitextensions/gitextensions/wiki/Translations