Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove VSIX from installer #5979

Closed
gerhardol opened this issue Dec 22, 2018 · 1 comment
Closed

Remove VSIX from installer #5979

gerhardol opened this issue Dec 22, 2018 · 1 comment

Comments

@gerhardol
Copy link
Member

Do you want to request a feature or report a bug?
feature

What is the current behavior?
The Visual Studio 2015-2017 vsix is included in the GE installer with an option to install.
The install option is copying the vsix to the GE installation dir. Installation can be done from the Program Files folder. This is not clear in the installer.
This option in the installer installed the old VS addin, the vsix was likely just added in a similar way

VSIX is officially distributed on VS Marketplace.

The vsix is a simple wrapper to call GE. It is visually updated in 3.0. In master VS2019 is enabled, that should be the official release.

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem.

What is the expected behavior?

  • Remove vsix from the installer.
  • Add vsix as an artifact in Appveyor builds
  • Possibly add vsix to downloads at release builds
  • Add the vsix in master to Marketplace

Environment you encounter the issue:

  • Git Extensions 3.00.00.4433
  • Build fca7cf2
  • Git 2.20.1.windows.1
  • Microsoft Windows NT 10.0.17134.0
  • .NET Framework 4.7.3260.0
  • DPI 96dpi (no scaling)

Did this work in previous version of GitExtensions (which)?
no

@vbjay
Copy link
Contributor

vbjay commented Dec 22, 2018 via email

@ghost ghost assigned gerhardol Feb 3, 2019
@ghost ghost added the status: ready label Feb 3, 2019
@RussKie RussKie added this to the 3.1.0 milestone Feb 8, 2019
@ghost ghost removed the status: ready label Feb 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants