Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git notes improvements #6039

Open
gerhardol opened this issue Jan 5, 2019 · 6 comments
Open

Git notes improvements #6039

gerhardol opened this issue Jan 5, 2019 · 6 comments

Comments

@gerhardol
Copy link
Member

gerhardol commented Jan 5, 2019

Feature description

From discussion in #6026 #5653 #6056
See also #4816, #1627 (part of #1627 fixed in #6026)

The proposal will be refined, a draft so far

Separate notes from message:

  • Do not fetch notes together with message (also when message is missing) but as a separate command (probably a configurable limit of notes, or use same as git-log).
  • Store separately from GitRevision (like a Dictionary)
  • Present separately in CommitInfo (and tooltip)
  • New column or overflow indicator (use multiline?) to show that notes exists.

Later:

Environment

  • Git Extensions 3.00.00.4433
  • Build fca7cf2
  • Git 2.20.1.windows.1
  • Microsoft Windows NT 10.0.17134.0
  • .NET Framework 4.7.3260.0
  • DPI 96dpi (no scaling)
@mstv
Copy link
Member

mstv commented Jan 7, 2019

Could you suppress the display of empty "Notes: " in the File History, too, please?

grafik

@gerhardol
Copy link
Member Author

Could you suppress the display of empty "Notes: " in the File History, too, please?

Should already be fixed in master as well as the release/3.00 branch

Present separately in CommitInfo (and tooltip)

In additions, the presentation should be separate (divider? separate area?) and only seen in commitinfo if existing.

@mstv
Copy link
Member

mstv commented Jan 7, 2019

It has been fixed only partially, namely in FormBrowse. I am complaining about File History.
Reproducible with:

  • Git Extensions 3.01.00.0
  • Build 5fa57a9
  • Git 2.20.0.windows.1
  • Microsoft Windows NT 6.1.7601 Service Pack 1
  • .NET Framework 4.7.2117.0
  • DPI 96dpi (no scaling)

@gerhardol
Copy link
Member Author

It has been fixed only partially, namely in FormBrowse. I am complaining about File History.

Reopened #5804

@RussKie
Copy link
Member

RussKie commented Jan 7, 2019

Present separately in CommitInfo (and tooltip)

In additions, the presentation should be separate (divider? separate area?) and only seen in commitinfo if existing.

Yes, in the future releases

@V0d01ey
Copy link

V0d01ey commented Nov 18, 2020

Additionally, there is a checkbox Main menu|View|Show git notes.
Now it does both:

  • shows Notes: in CommitInfo panel, and
  • shows branch notes/commits in Graph panel.

Though showing notes in commit info preferable in most use cases,
showing extra branch in graph makes the graph less convinient.
So, there should be different options for each case. Or simply make notes in commitInfo to show always.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants