Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete All no longer works - "not selectable" #6068

Closed
TamaMcGlinn opened this issue Jan 8, 2019 · 3 comments
Closed

Delete All no longer works - "not selectable" #6068

TamaMcGlinn opened this issue Jan 8, 2019 · 3 comments
Assignees
Labels
area: left-panel Issues related to the Left Panel type: bug 🐛
Milestone

Comments

@TamaMcGlinn
Copy link

Current behaviour

When you have some branches that begin with the same prefix followed by a "/", such as "feature/abc" and "feature/cba", right clicking the directory icon in the branches pane and clicking "Delete all", the resulting command gives an error: "Branch "feature/cba," is not selectable, this branch has been removed from the selection. The command will only delete the last branch in the list. Removing all the commas from the text field before clicking Delete fixes the problem.

Expected behaviour

The text field should not contain commas, so that the command succeeds without manual editing being necessary.

Screenshots

Delete All plus error message

Did this work in previous version of GitExtensions

Yes, this worked in GitExtensions 2.51 using Git 1.9.4. I upgraded to Git 2.20 in order to use GitExtensions 3, and this introduced this problem for me.

Environment

  • Git Extensions 3.00.00.03-RC2
  • 8cbcd2b (Dirty)
  • Git 2.20.0.rc1.windows.1
  • Microsoft Windows NT 6.1.7601 Service Pack 1
  • .NET Framework 4.7.3130.0
  • DPI X:100,00 % Y:100,00 %
@amaiorano amaiorano self-assigned this Jan 8, 2019
@amaiorano
Copy link
Contributor

I'll take care of this. I also noticed this bug with delete remote branch.

@gerhardol
Copy link
Member

Note: Side-panel is new in 3.0.0, so it cannot have worked before...

@TamaMcGlinn
Copy link
Author

@gerhardol Indeed, I was mistaken in which previous version I used. This works in GitExtensionsMod (2.53), a fork of GitExtensions which had merged that pane much earlier.

@ghost ghost removed the status: ready label Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: left-panel Issues related to the Left Panel type: bug 🐛
Projects
None yet
Development

No branches or pull requests

4 participants