Jira Commit Hint plugin doesn't work

[IEVin]

Current behaviour

Preview button in Jira commit hint plugin show dialog with error message.

Expected behaviour

Preview button in Jira commit hint plugin show dialog with available jira tasks.

Steps to reproduce

1. Open Tools/Settings/Plugins/Jira Commit Hint;
2. Configurate it and Press "Preview" button;
3. Get error dialog.

For reproduce this problem without correct configuration would be enought add StringTemplate.Format("", null); in JiraCommitHintPlugin constructor and get TypeLoadException while plugin loading.

Screenshots

Did this work in previous version of GitExtensions

Yes, it works correct on GE 3.00.00

Environment

• Git Extensions 3.0.1.4933
• Build a269358
• Git 2.19.2.windows.1
• Microsoft Windows NT 10.0.17134.0
• .NET Framework 4.7.3260.0
• DPI 96dpi (no scaling)

Diagnostics

Look like problem in wrong version of System.Collections.Immutable.dll.

[vbjay]

Great. c7e4f51

[vbjay]

Can you please open gitextensions.exe.config where you installed GE to and see if immutable is listed in the binding redirects and also find all .immutable.dll files and report on their version numbers.

[IEVin]

GitExtensions.exe.config have no any definitions .immutable.dll files. Only System.Collections.Concurrent and System.Collections.

[vbjay]

Search the folder for *.Immu*.dll Report on the versions of all files found, please.

[IEVin]

I found 2 files in root and in Plugins folder.
In root folder:
ProductVersion : 4.6.26515.06 @BuiltBy: dlab-DDVSOWINAGE059 @Branch: release/2.1 @SrcCode: https://github.com/dotnet/corefx/tree/30ab651fcb4354552bd4891619a0 bdd81e0ebdbf

In 'Plugins' folder:
ProductVersion : 4.6.24816.01. Commit Hash: 4d1af962ca0fede10beb01d197367c2f90e92c97

[vbjay]

Thank you. That will help me pin down the issue.

…

On Tue, Jan 22, 2019 at 10:20 AM Ivan Vinogradov ***@***.***> wrote: I found 2 files in root and in Plugins folder. In root folder: ProductVersion : 4.6.26515.06 @BuiltBy <https://github.com/BuiltBy>: dlab-DDVSOWINAGE059 @Branch <https://github.com/Branch>: release/2.1 @srccode <https://github.com/srccode>: https://github.com/dotnet/corefx/tree/30ab651fcb4354552bd4891619a0 bdd81e0ebdbf In 'Plugins' folder: ProductVersion : 4.6.24816.01. Commit Hash: 4d1af962ca0fede10beb01d197367c2f90e92c97 — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#6154 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADdhsaePWFvNsyQaVKtDWzz81mZCWsfRks5vFyxOgaJpZM4aMr8_> .

[vbjay]

Ok. Found the issue. In master we used the composition reference in plugins library. That caused a binding redirect between Nstring use of an earlier version of immutable and composition. I added a package reference to the same package in the Jira plugin and it makes the project use the same version. I will ask that you test the build once I get the pull request done. Look forward to an update soon.

[RussKie]

@vbjay is there a quick workaround/binding redirect users could apply to solve the issue?

[vbjay]

I'll look tonight. I'll generate a dll analysys from 3.02 tag build and report back to you then.

…

On Thu, Feb 21, 2019 at 3:59 PM RussKie ***@***.***> wrote: @vbjay <https://github.com/vbjay> is there a quick workaround/binding redirect users could apply to solve the issue? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#6154 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADdhsaxuna2uLcxdyImAOnzm6hLOn5IKks5vPwiZgaJpZM4aMr8_> .

[vbjay]

How I generated this output:

1. Run these git commands
   • git clean -d -x -f
   • git submodule foreach git clean -d -x -f
2. run setup\build
3. Run provided linqpad script on the root folder where I have GE repo. Adjust as needed

These are the dlls excluding *resources.dll that have different hashes. The config file shows the current assembly binding redirects when built.
GE 3.02 DLL analyze report.zip

[PaulAdams-Conti]

FYI, I have downloaded the latest source and compiled but even though there is no exception any longer, the text pasted into the commit box is not correct:

and then when it is pasted:

The colon and space are missing and the commits are not linked in Jira.

[IEVin]

FYI, I have downloaded the latest source and compiled but even though there is no exception any longer

This bug is only reproduced in the release/3.00 branch for me.

the text pasted into the commit box is not correct

The text template can be configured in the settings but it is not applied in the pop-up.

[PaulAdams-Conti]

Sorry for the confusion, my mistake. It had been working before so I assumed (wrongly) that I hadn't changed anything in the settings, but that was not the case. 🙄

[RussKie]

Is this still a problem in the latest master?
https://ci.appveyor.com/project/gitextensions/gitextensions/branch/master/artifacts

[gerhardol]

The portable works fine, have not tested the installer

[RussKie]

Let's presume it is fixed, thank you.

[zroytman]

Hi, i'm using GitExtensions 3.1.1 and have a placeholder {CustomFields} in the Jira Hint Comment plugin definition. Using this placeholder as is returns me the message that this is a collection. How can i specify the custom field from this collection? The required custom field is "Application". Tried several ways like {CustomFields["Application"]}, {CustomFields("Application")}. {CustomFields.Application}, etc... getting error messages.
Please help.
Thanks.

[zroytman]

Hi, i'm using GitExtensions 3.1.1 and have a placeholder {CustomFields} in the Jira Hint Comment plugin definition. Using this placeholder as is returns me the message that this is a collection. How can i specify the custom field from this collection? The required custom field is "Application". Tried several ways like {CustomFields["Application"]}, {CustomFields("Application")}. {CustomFields.Application}, etc... getting error messages.
Please help.
Thanks.

H! Any updates? Thanks.

[IEVin]

There is no way to get an array element now. GE using NString for parsing jira issue object but NString can only get fields and properties from top level object.
In fact fields like AffectsVersions, CustomFields, FixVersions, Labels is useless now.
This is an NString restriction.

[zroytman]

There is no way to get an array element now. GE using NString for parsing jira issue object but NString can only get fields and properties from top level object.
In fact fields like AffectsVersions, CustomFields, FixVersions, Labels is useless now.
This is an NString restriction.

Thanks for the explanation. Is this functionality presented in the GE roadmap? If so, any expectation of the implementation of it? Thanks.

[pmiossec]

Is this functionality presented in the GE roadmap?

There is no roadmap other than a list of bug that we'd like to see fixed. See https://github.com/gitextensions/gitextensions/issues?q=is%3Aopen+is%3Aissue+milestone%3A3.2.0

But we live with contributions (we are all volunteers), so if you want to see something fixed or improved, please contribute.

[IEVin]

Thanks for the explanation. Is this functionality presented in the GE roadmap? If so, any expectation of the implementation of it? Thanks.

I think no. You can add new issue about this. I think it's a good idea add issue in NString repository and just update it after implement this feature.

[RussKie]

I'm more than happy to see NString gone, if it'd help in fixing the issue.

…

On Tue, Jun 25, 2019, 7:53 PM Ivan Vinogradov ***@***.***> wrote: Thanks for the explanation. Is this functionality presented in the GE roadmap? If so, any expectation of the implementation of it? Thanks. I think no. You can add new issue about this. I think is a good idea add issue in NString <https://github.com/thomaslevesque/NString> repository and just update it after implement this feature. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#6154?email_source=notifications&email_token=ABBTEXVVX77KJ42ORVFTCBDP4HTJTA5CNFSM4GRSX472YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYPWGZQ#issuecomment-505373542>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABBTEXQNPV76IEQ3C4MH2LDP4HTJTANCNFSM4GRSX47Q> .

[zroytman]

Thanks for the explanation. Is this functionality presented in the GE roadmap? If so, any expectation of the implementation of it? Thanks.

I think no. You can add new issue about this. I think it's a good idea add issue in NString repository and just update it after implement this feature.

Opened a new issue in NString repository:
thomaslevesque/NString#13 (comment)

[IEVin]

Now GE just getting jira issue and put it in StringTemplate.Format(...) with user format without any aditional parsing (click).
Either add this feature in NString or implement formatter like NString itself.

[pmiossec]

Opened a new issue in NString repository:

@zroytman I think that your issue title and description should be rewritten.
All the information you provided talk about GitExtensions which the developer of NString should not know of.
That don't help him understand what is the problem you want him to fix (I don't understand it neither).

Your text should be written in the point of view of the NString library perhaps with some source code examples.

[zroytman]

Opened a new issue in NString repository:

@zroytman I think that your issue title and description should be rewritten.
All the information you provided talk about GitExtensions which the developer of NString should not know of.
That don't help him understand what is the problem you want him to fix (I don't understand it neither).

Your text should be written in the point of view of the NString library perhaps with some source code examples.

As i don't understand what is the real problem (NString etc...), i just describe my issue. No source code examples to add... i just asked why cannot i use specific field from CustomFields placeholder in GE Jira Hint Comment plugin. You guys explained here that the reason is the limitations of NString and i opened a relevant case in NString repository. But i even don't know what is NString.