Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for VS2019 #6431

Closed
SeanFeldman opened this issue Apr 3, 2019 · 13 comments
Closed

Support for VS2019 #6431

SeanFeldman opened this issue Apr 3, 2019 · 13 comments
Milestone

Comments

@SeanFeldman
Copy link

What version to expect support for VS2019?

@Aleksanderis
Copy link

Aleksanderis commented Apr 3, 2019

Quick workaround until official supported version is released: download *.msi installer, extract it, find there GitExtensoinsVSIX.vsix, which is also just a packed archive. Extract GitExtensoinsVSIX.vsix and modify extension.vsixmanifest, changing following line:

<InstallationTarget Version="[14.0,17.0)" Id="Microsoft.VisualStudio.Community" />
to:
<InstallationTarget Version="[14.0,18.0)" Id="Microsoft.VisualStudio.Community" />

Add modified file to GitExtensoinsVSIX.vsix.

@RussKie
Copy link
Member

RussKie commented Apr 3, 2019

A PR is welcome 😏

@RussKie RussKie added this to the 3.1.0 milestone Apr 3, 2019
@vbjay
Copy link
Contributor

vbjay commented Apr 3, 2019

#5864

@vbjay
Copy link
Contributor

vbjay commented Apr 3, 2019

What we really need is ci publish to marketplace.

@RussKie
Copy link
Member

RussKie commented Apr 3, 2019

Sadly #5864 isn't addressing the question, a tweak is still required.

I reached out to @spdr870, but we need to build the publishing pipeline
https://docs.microsoft.com/en-us/visualstudio/extensibility/walkthrough-publishing-a-visual-studio-extension-via-command-line?view=vs-2019

@gerhardol
Copy link
Member

The code is changed, just not uploaded:
https://ci.appveyor.com/project/gitextensions/gitextensions/branch/master/artifacts

@RussKie
Copy link
Member

RussKie commented Apr 3, 2019

I've up'ed the limit to 18.0
I'll get @spdr870 to upload a new version to the marketplace.

@RussKie
Copy link
Member

RussKie commented Apr 4, 2019

Could you please test this VSIX - https://ci.appveyor.com/api/buildjobs/1w36e8fgfvysdwn4/artifacts/GitExtensionsVSIX%2Fbin%2FRelease%2FGitExtensionsVSIX.vsix

If it is good, we'll get it published to the marketplace

@miki-bgd
Copy link

miki-bgd commented Apr 4, 2019

Installed on VS community 2019.
The only thing is that it wasn't added as a new menu item, but as a submenu under Extensions.
Here is the image.

gitext

@Aleksanderis
Copy link

Installed on VS community 2019.
The only thing is that it wasn't added as a new menu item, but as a submenu under Extensions.
Here is the image.

gitext

I think it will be as by design now. For example - ReSharper is also being added to same menu. So maybe Visual Studio is restricting to override it, to reduce the UI clutter.

@miki-bgd
Copy link

miki-bgd commented Apr 4, 2019

Yes, it seems.

In VS 2019, top level menus contributed by extensions are placed under the Extensions menu.

As from here: docs.microsoft.com

However, it is possible to create manually top level menu, and add commands one by one. But for now i couldn't find solution just to move complete group.

@spdr870
Copy link
Member

spdr870 commented Apr 4, 2019

@RussKie requested my to uploaded a new VSIX. I just uploaded it to the visual studio marketplace. It is currently validating the upload, that will take a little time.

Edit: The new vsix is active now. https://marketplace.visualstudio.com/items?itemName=HenkWesthuis.GitExtensions

@spdr870
Copy link
Member

spdr870 commented Apr 4, 2019

About the token for the automated upload, I would like to transfer the project from HenkWesthuis.GitExtensions to GitExtensions.GitExtensions. I think its better to create the token after the transfer. I can also add members to the project then. I probably will do this in the upcoming days. Its not a lot of work, but I want to make sure it won't break existing installations.

@RussKie RussKie closed this as completed Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants