VS2019 initial support

[NN---]

Allow installation of VSIX in VS2019.
https://madskristensen.net/blog/how-to-upgrade-extensions-to-support-visual-studio-2019/

• Git Extensions 3.00.00.4433
• Build fca7cf2
• Git 2.19.2.windows.1
• Microsoft Windows NT 10.0.17763.0
• .NET Framework 4.7.3260.0
• DPI 120dpi (125% scaling)

[vbjay]

Does this fail to install? https://marketplace.visualstudio.com/items?itemName=HenkWesthuis.GitExtensions

…

On Fri, Dec 7, 2018 at 4:15 PM NN ***@***.***> wrote: Allow installation of VSIX in VS2019. https://madskristensen.net/blog/how-to-upgrade-extensions-to-support-visual-studio-2019/ ------------------------------ You can view, comment on, or merge this pull request online at: #5864 Commit Summary - VS2019 initial support File Changes - *M* GitExtensionsVSIX/source.extension.vsixmanifest <https://github.com/gitextensions/gitextensions/pull/5864/files#diff-0> (4) Patch Links: - https://github.com/gitextensions/gitextensions/pull/5864.patch - https://github.com/gitextensions/gitextensions/pull/5864.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#5864>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADdhsXXlKbsby3GeIHi4tguTM0V0Kd5Rks5u2tp4gaJpZM4ZJKAQ> .

[NN---]

Haven't tried it yet.
Usually extensions don't work if you don't allow installation for newer VS version.
This blog post is from VS extensions developer, he has a lot of experience in this area.

[gerhardol]

Seem reasonable. How did you test it?

[NN---]

Installed VS2019 preview https://visualstudio.microsoft.com/vs/preview/
Running the VSIX I don't see option to integrate into 2019, only 2017 is listed.

[vbjay]

Cool. Just checking. Good to know. We have a pull request and issue template for a reason.

[codecov]

Codecov Report

Merging #5864 into master will decrease coverage by 0.5%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #5864      +/-   ##
=========================================
- Coverage    37.3%   36.8%   -0.51%     
=========================================
  Files         618     618              
  Lines       47391   49172    +1781     
  Branches     6299    6836     +537     
=========================================
+ Hits        17679   18096     +417     
- Misses      28935   30259    +1324     
- Partials      777     817      +40

[RussKie]

Thank you

[gerhardol]

I want to have this in the VSIX update for the market place (@RussKie, I added to the 3.00.01 milestone)
@NN--- Can you submit a PR for release/3.00 too?

[RussKie]

I cherrypicked it into release/3.00, will push it soon

…

On Mon, Dec 10, 2018, 7:13 PM Gerhard Olsson ***@***.***> wrote: I want to have this in the VSIX update for the market place ***@***.*** <https://github.com/RussKie>, I added to the 3.00.01 milestone) @NN--- <https://github.com/NN---> Can you submit a PR for release/3.00 too? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5864 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEMyXt_8-vXaFtBn1L5rErGvrpjRUwgBks5u3hePgaJpZM4ZJKAQ> .

[nul800sebastiaan]

Is the VSIX available yet somewhere?

[vbjay]

Note the milestone. We are working on releasing 3.0.1.

[nul800sebastiaan]

@vbjay Great, thanks! Now that 3.0.1 is out, where would I find the VISX though? :-) The MSI installer doesn't offer integration with VS19 and I can't find an update in the VS marketplace.

I've tried updating the old VSIX with the manifest changes from this PR but it refuses to install but it doesn't give me a good reason other than "prerequisites" that are missing.

[nul800sebastiaan]

Alright, that was a typo on my part, got a little further now but it crashes on a missing reference to Microsoft.VisualStudio.Component.CoreEditor.

Manifest looks like:

<?xml version="1.0" encoding="utf-8"?>
<PackageManifest Version="2.0.0" xmlns="http://schemas.microsoft.com/developer/vsx-schema/2011">
    <Metadata>
        <Identity Publisher="GitExt Team" Version="2.50.2" Language="en-US" Id="GitExtensions..550013F4-337C-4750-8967-DDEEEC2EB497" />
        <DisplayName>GitExtensions</DisplayName>
        <Description xml:space="preserve" >Git Extensions is a graphical user interface for Git that allows you to control Git without using the command-line</Description>
        <MoreInfo>https://gitextensions.github.io/</MoreInfo>
        <License>Resources\LICENSE.md</License>
        <GettingStartedGuide>https://git-extensions-documentation.readthedocs.io/en/latest/</GettingStartedGuide>
        <Icon>Resources\git-extensions-logo-32px.png</Icon>
        <PreviewImage>Resources\git-extensions-logo-256px.png</PreviewImage>
        <Tags>Git, Git Extensions</Tags>
    </Metadata>
    <Installation>
        <InstallationTarget Version="[14.0,17.0)" Id="Microsoft.VisualStudio.Community" />
    </Installation>
    <Dependencies>
        <Dependency Id="Microsoft.Framework.NDP" DisplayName="Microsoft .NET Framework" Version="4.0" />
        <Dependency Id="Microsoft.VisualStudio.MPF.14.0" DisplayName="Visual Studio MPF 14.0" Version="[14.0,15.0)" />
    </Dependencies>
    <Assets>
		<Asset Type="Microsoft.VisualStudio.VsPackage" Path="GitExtensionsVSIX.pkgdef" />
    </Assets>
    <Prerequisites>
        <Prerequisite Id="Microsoft.VisualStudio.Component.CoreEditor" Version="[14.0,)" DisplayName="Visual Studio core editor" />
    </Prerequisites>
</PackageManifest>

[nul800sebastiaan]

Aha! It was in the MSI file, just didn't offer an install from the MSI for some reason. If anyone else is looking for it, download and rename this file to GitExtensionsVSIX.vsix 👍

GitExtensionsVSIX.zip

Works! 🎉

[gerhardol]

It was in the MSI file, just didn't offer an install from the MSI for some reason.

"Install" vsix feature just unpacks from the MSI, this as intended.
The file is distributed that way too, should be put on VS marketplace too by someone with privileges.
The .vsix will be removed from the msi, I want to deliver it as a separate Artifact too.