Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull dialog stopped "remembering" previous user selection #6503

Closed
GStoynev opened this issue Apr 23, 2019 · 3 comments · Fixed by #6613
Closed

Pull dialog stopped "remembering" previous user selection #6503

GStoynev opened this issue Apr 23, 2019 · 3 comments · Fixed by #6613
Assignees
@RussKie
Labels
status: reproducible type: regression regression, normally to latest official release
Milestone
3.1.1

Comments

@GStoynev
Copy link

GStoynev commented Apr 23, 2019 •
edited

Replicate:

  1. In the UI, ensure "Open Pull dialog ..." is used (either "set as default" ot clicked)
  2. Choose "Merge remote branch into current" option.
  3. Check "Auto stash" checkbox
  4. Pull
  5. Once the dialog is closed, repeat step 1.

Current behaviour

When re-opened, the dialog doesn't "remember" that I chose the option and the checkbox in 2. and 3. above

Expected behaviour

When reopened, the dialog's initial state will match the selections from the last time I used it.

This used to be the default behavior for as long as I remember using GitExtensions - since 2013 or so... I think it got broken in the 3.0 release.

Environment

  • Git Extensions 3.0.2.5232
  • Build 23b6f51
  • Git 2.20.1.windows.1
  • Microsoft Windows NT 10.0.17134.0
  • .NET Framework 4.7.3394.0
  • DPI 96dpi (no scaling)
@RussKie RussKie added 👓 status: needs review type: regression regression, normally to latest official release labels Apr 23, 2019
@Shauren
Copy link
Contributor

Shauren commented May 20, 2019 •
edited

I can confirm this behavior when I tried to upgrade from 2.51.05 to 3.1 while keeping my settings (IsPortable = false)
For me this is a major upgrade-blocking issue

@RussKie RussKie self-assigned this May 20, 2019
@RussKie RussKie added this to the 3.1.1 milestone May 20, 2019
RussKie added a commit to RussKie/gitextensions that referenced this issue May 20, 2019
@RussKie
fix: Pull dialog not remember user selection
691c45b 
If "Open Pull dialog ..." is set as a default pull operation, the pull
dialog does not have correct settings preselected upon open.
Also since refactors in v3 pull dialog does not remember user selection
(such as `Auto stash`).

The fix restores `FormPullAction` setting that remembers user's selection
in the dialog.
The fix also restores the capture of `AutoStash` selection.

Fixes gitextensions#6503
@RussKie RussKie mentioned this issue May 20, 2019
Merged
RussKie added a commit to RussKie/gitextensions that referenced this issue May 20, 2019
@RussKie
fix: Pull dialog not remember user selection
7ae5da5 
If "Open Pull dialog ..." is set as a default pull operation, the pull
dialog does not have correct settings preselected upon open.
Also since refactors in v3 pull dialog does not remember user selection
(such as `Auto stash`).

The fix restores `FormPullAction` setting that remembers user's selection
in the dialog.
The fix also restores the capture of `AutoStash` selection.

Fixes gitextensions#6503

(cherry picked from commit 691c45b)
@RussKie RussKie mentioned this issue May 20, 2019
Merged
@RussKie
Copy link
Member

RussKie commented May 20, 2019

Could you please try the fix https://ci.appveyor.com/api/buildjobs/t962yn1m4uaf2yf2/artifacts/combined.3.1.1.585-unsigned.zip

@Shauren
Copy link
Contributor

Shauren commented May 20, 2019

This works just like on 2.51, perfect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RussKie RussKie

Labels
status: reproducible type: regression regression, normally to latest official release
Projects
None yet
Milestone
3.1.1
Development

Successfully merging a pull request may close this issue.

fix: Pull dialog not remember user selection RussKie/gitextensions
3 participants
@Shauren @GStoynev @RussKie