version 3.2 not installable on Win7

[mast-eu]

Current behaviour

I was testing the MSI for the upcoming 3.2 release. Seems like it can be normally installed on Win10, but not on Win7.
Could someone on Win7 please doublecheck?

Expected behaviour

Installs also on Win7 without issues.

Steps to reproduce

1. Download the artifact from https://ci.appveyor.com/project/gitextensions/gitextensions/builds/26854222/artifacts. This is build 6443, coresponding to 6fe0126, the current tip of branch release/3.2.
2. Extract the ZIP archive and launch GitExtensions-3.2.0.6443.msi, just like you normally would.
3. Go through the configuration dialogs. As far as I can tell, it doesn't matter what options you select. Go with your preferences.
4. After the last dialog, the installer will start installing GitExtension 3.2, but roll back everything before finishing.

Screenshots

Did this work in previous version of GitExtensions

Yes.

Debug

Launch the installer again from command line with msiexec.exe /i GitExtensions-3.2.0.6443.msi /L*vx! debug.log. This creates a detailed log file.

I think the key part is:

Action 23:48:35: ConfigureTelemetry. 
MSI (s) (90:08) [23:48:35:762]: Executing op: CustomActionSchedule(Action=ConfigureTelemetry,ActionType=1025,Source=BinaryData,Target=WixQuietExec,CustomActionData="C:\Windows\SysWOW64\WindowsPowerShell\v1.0\powershell.exe" -Version 3.0 -NoProfile -NonInteractive -InputFormat None -ExecutionPolicy Bypass -Command "& 'C:\Program Files (x86)\GitExtensions\set-telemetry.ps1' 1 ; exit $($Error.Count)")
MSI (s) (90:D8) [23:48:35:765]: Invoking remote custom action. DLL: C:\Windows\Installer\MSIC876.tmp, Entrypoint: WixQuietExec
WixQuietExec:  Impossibile avviare Windows PowerShell versione 3.0 perch‚ non Š installato correttamente.
WixQuietExec:  Error 0xfffa0000: Command line returned an error.
WixQuietExec:  Error 0xfffa0000: QuietExec Failed
WixQuietExec:  Error 0xfffa0000: Failed in ExecCommon method
CustomAction ConfigureTelemetry returned actual error code 1603 (note this may not be 100% accurate if translation happened inside sandbox)
Action ended 23:48:35: InstallFinalize. Return value 3.

Basically, it is trying to run PowerShell 3.0, which is not available on Win7.

[RussKie]

W7 or W7SP1?

…

On Sat, Aug 31, 2019, 12:38 AM Martin Steinisch ***@***.***> wrote: Current behaviour I was testing the MSI for the upcoming 3.2 release. Seems like it can be normally installed on Win10, but *not on Win7*. Could someone on Win7 please doublecheck? Expected behaviour Installs also on Win7 without issues. Steps to reproduce 1. Download the artifact from https://ci.appveyor.com/project/gitextensions/gitextensions/builds/26854222/artifacts. This is build 6443, coresponding to 6fe0126 <6fe0126>, the current tip of branch release/3.2 <https://github.com/gitextensions/gitextensions/tree/release/3.2>. 2. Extract the ZIP archive and launch GitExtensions-3.2.0.6443.msi, just like you normally would. 3. Go through the configuration dialogs. As far as I can tell, it doesn't matter what options you select. Go with your preferences. 4. After the last dialog, the installer will start installing GitExtension 3.2, but roll back everything before finishing. Screenshots [image: Untitled] <https://user-images.githubusercontent.com/46861028/64052309-51311600-cb7e-11e9-93a7-14aea3c018b1.png> Did this work in previous version of GitExtensions Yes. Debug Launch the installer again from command line with msiexec.exe /i GitExtensions-3.2.0.6443.msi /L*vx! debug.log. This creates a detailed log file. I think the key part is: Action 23:48:35: ConfigureTelemetry. MSI (s) (90:08) [23:48:35:762]: Executing op: CustomActionSchedule(Action=ConfigureTelemetry,ActionType=1025,Source=BinaryData,Target=WixQuietExec,CustomActionData="C:\Windows\SysWOW64\WindowsPowerShell\v1.0\powershell.exe" -Version 3.0 -NoProfile -NonInteractive -InputFormat None -ExecutionPolicy Bypass -Command "& 'C:\Program Files (x86)\GitExtensions\set-telemetry.ps1' 1 ; exit $($Error.Count)") MSI (s) (90:D8) [23:48:35:765]: Invoking remote custom action. DLL: C:\Windows\Installer\MSIC876.tmp, Entrypoint: WixQuietExec WixQuietExec: Impossibile avviare Windows PowerShell versione 3.0 perch‚ non Š installato correttamente. WixQuietExec: Error 0xfffa0000: Command line returned an error. WixQuietExec: Error 0xfffa0000: QuietExec Failed WixQuietExec: Error 0xfffa0000: Failed in ExecCommon method CustomAction ConfigureTelemetry returned actual error code 1603 (note this may not be 100% accurate if translation happened inside sandbox) Action ended 23:48:35: InstallFinalize. Return value 3. Basically, it is trying to run PowerShell 3.0, which is not available on Win7. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#7079?email_source=notifications&email_token=ABBTEXSVGDSFKBHFUSTQ3XTQHGHOLA5CNFSM4ISRLIA2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HIRNB6A>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABBTEXTQ6AUFP5MMOQAOCCTQHGHOLANCNFSM4ISRLIAQ> .

[mast-eu]

Up-to-date Win7 SP1 (Home Premium) with PowerShell 2.0.

> $PSVersionTable

Name                           Value                                           
----                           -----                                           
CLRVersion                     2.0.50727.8806                                  
BuildVersion                   6.1.7601.17514                                  
PSVersion                      2.0                                             
WSManStackVersion              2.0                                             
PSCompatibleVersions           {1.0, 2.0}                                      
SerializationVersion           1.1.0.1                                         
PSRemotingProtocolVersion      2.1  

[RussKie]

Can you try changing this to PS 2.0 and see if it fixes it?
https://github.com/gitextensions/gitextensions/blob/master/Setup/UI/TelemetryDlg.wxs#L20

[mast-eu]

Can you try changing this to PS 2.0 and see if it fixes it?

I tried, and it did not fix it. However, you helped me to get further:
Now it's complaining that the method IsNullOrWhitespace in

gitextensions/Bin/set-telemetry.ps1

Line 6 in 149437c

[bool]$telemetryEnabled = -not [string]::IsNullOrWhiteSpace($Enabled);

hasn't been found. In fact, IsNullOrWhitespace does not exist in PowerShell 2.0. I have IsNullOrEmpty, though.
Thus, I changed the line to [bool]$telemetryEnabled = -not [string]::IsNullOrEmpty($Enabled); , built the MSI again and ran it on my Win7 machine.

This time, the installation was successful and in GitExtensions.settings I find

<item>
   <key>
     <string>TelemetryEnabled</string>
   </key>
   <value>
     <string>True</string>
   </value>
 </item>

So it's seems to work. I write seems, because, using IsNullOrEmpty was just a quick shot from the hip:

• I did not test on Win10.
• I did not test to disable telemetry (i.e. to change the passed parameter).
• I am not sure that this will always work as intended.

Maybe tomorrow I can dedicate more time on this, if needed.

[RussKie]

hasn't been found. In fact, IsNullOrWhitespace does not exist in PowerShell 2.0. I have IsNullOrEmpty, though.
Thus, I changed the line to [bool]$telemetryEnabled = -not [string]::IsNullOrEmpty($Enabled); , built the MSI again and ran it on my Win7 machine.

Great! It is perfectly valid to use IsNullOrEmpty, I just made a habbit of using IsNullOrWhitespace.

You could also write the line as follows:

[bool]$telemetryEnabled = ![string]::IsNullOrEmpty($Enabled);

I have done quite a bit of testing of the original change for various use-cases, so it should "just work" (c) 😎

[RussKie]

As part of your fix I suggest to add a comment before line 17 in TelemetryDlg.wxs saying something like:

"<!-- Windows 7SP1 supports only PowerShell 2.0 -->"

[mast-eu]

I could probably send a PR this evening (CET). Do you prefer it to master, release/3.2 or both branches?

[RussKie]

3.2 for now, thank you

…

On Mon, Sep 2, 2019, 2:15 PM Martin Steinisch ***@***.***> wrote: I could probably send a PR this evening (CET). Do you prefer it to master, release/3.2 or both branches? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#7079?email_source=notifications&email_token=ABBTEXSEL3H2PH63QM7EJPTQHTYV5A5CNFSM4ISRLIA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5VQ34Y#issuecomment-527109619>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABBTEXWNYFT6N7DFBF2Z2DLQHTYV5ANCNFSM4ISRLIAQ> .