Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NBug] Illegal characters in path. #8570

Closed
richhock opened this issue Oct 24, 2020 · 2 comments
Closed

[NBug] Illegal characters in path. #8570

richhock opened this issue Oct 24, 2020 · 2 comments

Comments

@richhock
Copy link

⚠️ The sections below must be filled in and this text must be removed or the issue will be closed.

Current behaviour

Expected behaviour

Steps to reproduce

Error Details

System.ArgumentException: Illegal characters in path.
   at System.IO.Path.CheckInvalidPathChars(String path, Boolean checkAdditional)
   at System.IO.Path.IsPathRooted(String path)
   at GitCommands.FullPathResolver.Resolve(String path)
   at GitUI.Editor.FileViewer.SetVisibilityDiffContextMenu(Boolean visibleTextFile, String fileName)
   at GitUI.Editor.FileViewer.ResetForDiff(String fileName)
   at GitUI.Editor.FileViewer.<>c__DisplayClass103_0.<ViewPatchAsync>b__0()
   at GitUI.Editor.FileViewer.ShowOrDeferAsync(Int64 contentLength, Func`1 showFunc)
   at GitUI.Editor.FileViewer.<ViewPatchAsync>d__103.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at GitUI.CommandsDialogs.RevisionDiffControl.<ShowSelectedFileDiffAsync>d__35.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at GitUI.CommandsDialogs.RevisionDiffControl.<<DiffFiles_SelectedIndexChanged>b__36_0>d.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at GitUI.ThreadHelper.<>c__DisplayClass13_0.<<FileAndForget>b__0>d.MoveNext()

Additional information

Clicked on a commit pulled from a github wiki with a file whose name contained many symbols.

Environment

  • Git Extensions 3.4.3.9999
  • Build d4b0f48
  • Git 2.20.1.windows.1 (recommended: 2.25.1 or later)
  • Microsoft Windows NT 10.0.19041.0
  • .NET Framework 4.8.4250.0
  • DPI 96dpi (no scaling)
@duplicates-detector-bot
Copy link

Potential duplicates:

  • #6981
  • #6982
  • #7528
  • #7592
  • #7601
  • #7608
  • #7643
  • #7722
  • #7799
  • #7860
  • #7862
  • #7936
  • #7977
  • #8005
  • #8052
  • #8090
  • #8107
  • #8151
  • #8202
  • #8259
  • #8282
  • #8364
  • #8383

@richhock
Copy link
Author

richhock commented Oct 24, 2020

I recreated #8571 with more details in the description.
Edit: Added reference

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant