Cancel unfinished/hanging git log

[mstv]

Most likely a git issue:
I have filtered with Diff contains (SLOW). But the git command has not returned for almost 6 hours - I guess due to a child process astextplain. pdf2text.exe seems to block in conjunction with a pipe to "C:\Program Files\Git\usr\bin\sed.exe" s/(\^M$)|(^\^L)//.
After killing pdf2text.exe, another one is started for the next PDF.
These PDFs are stored in Git LFS. But the temp files have not been expanded.

This even blocks GE from switching repos.
I agree with @gerhardol: A yet running git log command should be canceled/killed when refreshing the RevisionGrid.

• Git Extensions 33.33.33
• Build 825d380
• Git 2.30.1.windows.1
• Microsoft Windows NT 10.0.19043.0
• .NET 5.0.5
• DPI 96dpi (no scaling)

Originally posted by @mstv in #9393 (comment)

[mstv]

Diff contains git-log -G is not working as expected, I do not get the results I expect and the graph is incorrect. (--parents are not included by default, can be forced by adding a path filter like "**/*" "**/*").

Perhaps yet another issue.

There are pure GE issues too, like the left panel pumps out git branch --format=%(refname) -a --merged HEAD while git-log -G runs.

Do you think this will cause issues? Which? Due to parallel execution? It makes sense to me to run this command if a revision has been selected.

In your case I assume that you have changed .gitattributes for *.pdf.
I assume -G generates the diff to find matches, this will be slow if searching all commits.

pdf2text hung while processing the temp file which contained only the LFS link.
Git continued with the next PDF only when I killed pdf2text.

[gerhardol]

RevisionReader has cancellation implementation, need to be added to RevisionGridControl (maybe passing the token to RevisionReader).

This was with git-log -G, but also normal git-log may require tenths of seconds.
The filter handling with -G can take this to extremes...

[mstv]

might be solved with #9818

[gerhardol]

might be solved with #9818

The git-log executable in RevisionReader uses IGitCommandRunner that accesses IProcess directly.
The cancellation token is checked in RevisionReader, must kill the process explicitly.

So if #9818 is extended from the IExecutable interface (which was what I considered) to also include IGitCommandRunner it is included.