Exclude boundary commits with --grep #10076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Do we tests for this?
|
No. It seems like there is no reasoning to the configuration, which is needed first. |
Incorrect label for search with --grep
gerhardol
force-pushed
the
feature/i10074-grep-boundary
branch
from
378b3ab
to
d83563f
Compare
|
Rebased, added a stupid test |
RussKie
reviewed
Jul 24, 2022
RussKie
approved these changes
Jul 25, 2022
RussKie
pushed a commit
that referenced
this pull request
Jul 28, 2022
Incorrect label for search with --grep (cherry picked from commit 02173f3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10074
Proposed changes
git-log --boundary and --all is included in many revision listings. (The options are currently used together.)
This basically means that the parent to matches is included. This may be desired in some situations, but not with
--grep.It is not obvious that --boundary and --grep should be used where they are used now.
Similarly, -all may still be used with --grep. (I do not see how that is used at all though.)
The options can be tuned and expanded in general...
Also fixed the label for search.
Screenshots
Before
After
Test methodology
Manual
Merge strategy
I agree that the maintainer squash merge this PR (if the commit message is clear).
✒️ I contribute this code under The Developer Certificate of Origin.