RevGrid: Optimize onlyFirstParent handling #10082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
RussKie
approved these changes
Jul 25, 2022
RussKie
pushed a commit
that referenced
this pull request
Jul 28, 2022
Co-authored-by: Gerhard Olsson <gerhardol@users.noreply.github.com> (cherry picked from commit 1c9cbb2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Further optimizations loading revisions, while adding revisions to the grid (while 'Loading' is shown).
Measuring with StopWatch in a Release builds, this measures <1 ms vs 30-60 ms.
Note:
_gridView.Add(revision, flags);requires 250 ms for me which is actually less than I expected.There may still be optimizations there, but I doubt it will be much. (Maybe the GUI updates can be improved more.)
The refs datastructure could maybe be improved too, but that is only about 10 ms, so not much gain.
Further loading improvements should be possible with caching of commands affected by worktree/index changes, which is tricky.
Test methodology
Manual
Merge strategy
I agree that the maintainer squash merge this PR (if the commit message is clear).
✒️ I contribute this code under The Developer Certificate of Origin.