Use WinForms API to check for minimized #10088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
RussKie
approved these changes
Jul 26, 2022
RussKie
pushed a commit
that referenced
this pull request
Jul 28, 2022
(cherry picked from commit 35e75c5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Use WinForms API instead of native calls to check if the application is minimized.
This is used by GitStatusMonitor to skip updates for minimized instances as git-status can use quite some CPU/IO resources.
(The taskbar quick button is then greyed out.)
The intention with the changes was to investigate if the native calls for some reason was involved in the problem seen in #9752, which does not seem to be the case.
(I wrote this originally, did not know about the WinForms API at that time.)
Test methodology
Manual
Merge strategy
I agree that the maintainer squash merge this PR (if the commit message is clear).
✒️ I contribute this code under The Developer Certificate of Origin.