Eliminate static methods in RevisionReader #10130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
gerhardol
force-pushed
the
feature/i5371-revision-reader-nostatic
branch
from
5d0379c
to
3398a93
Compare
|
Rebased on #10129 (after multiple changes in master). Squashed the minor fixup. |
gerhardol
force-pushed
the
feature/i5371-revision-reader-nostatic
branch
from
3398a93
to
c86f028
Compare
RussKie
approved these changes
Sep 3, 2022
Simplify (and a minor optimization) the code when loading revisions. RevisionNodeFlags has information that is already available in the GitRevisions, no need to pass that info again. Set HasNotes after revisions are loaded, that is not required when displaying a revisions.
gerhardol
force-pushed
the
feature/i5371-revision-reader-nostatic
branch
from
5d65304
to
3c32f44
Compare
gerhardol
added a commit
that referenced
this pull request
Sep 4, 2022
Simplify (and a minor optimization) the code when loading revisions. RevisionNodeFlags has information that is already available in the GitRevisions, no need to pass that info again. Set HasNotes after revisions are loaded, that is not required when displaying a revisions. (cherry picked from commit bbab8ab)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparation for #5371
The end result is pushed to feature/i5371-stash-in-grid
For all stashes (not just the latest)
Not required for 4.0 but should be considered
Proposed changes
Eliminate static methods in RevisionReader
Prepare RevisionReader for added functionality.
Avoid passing class instance variable with every call.
Parsing revisions may be improved by a milli second in best case.
Remove RevisionNodeFlags from data grid
Simplify (and a minor optimization) the code when loading revisions.
RevisionNodeFlags has information that is already available in the
GitRevisions, no need to pass that info again.
Set HasNotes after revisions are loaded, that is not required when
displaying a revision.
Test methodology
Tests are updated
Merge strategy
✒️ I contribute this code under The Developer Certificate of Origin.